Bug 107102

Summary: Web Inspector: add createOption method to WebInspector.StatusBarComboBox
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Andrey Adaikin <aandrey>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch vsevik: review+, vsevik: commit-queue-

Andrey Adaikin
Reported 2013-01-17 00:40:07 PST
Patch to follow.
Attachments
Patch (6.59 KB, patch)
2013-01-17 00:46 PST, Andrey Adaikin 		vsevik: review+
vsevik: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2013-01-17 00:46:58 PST
Created attachment 183137 [details] Patch
Vsevolod Vlasov
Comment 2 2013-01-17 01:01:30 PST
Comment on attachment 183137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183137&action=review > Source/WebCore/inspector/front-end/ConsoleView.js:203 > this._contextSelector.addOption(option); remove this line > Source/WebCore/inspector/front-end/StatusBarButton.js:142 > + this.element.removeStyleClass("toggled-" + this._state); Previously this was only done inside if clause. Why is it correct to take it out? > Source/WebCore/inspector/front-end/StatusBarButton.js:311 > + if (value !== "undefined") typeof value !== ...
Andrey Adaikin
Comment 3 2013-01-17 01:05:08 PST
Comment on attachment 183137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183137&action=review >> Source/WebCore/inspector/front-end/ConsoleView.js:203 >> this._contextSelector.addOption(option); > > remove this line done. good catch! >> Source/WebCore/inspector/front-end/StatusBarButton.js:142 >> + this.element.removeStyleClass("toggled-" + this._state); > > Previously this was only done inside if clause. Why is it correct to take it out? This was done inside *both* if- and else- clauses, thus I took it out. >> Source/WebCore/inspector/front-end/StatusBarButton.js:311 >> + if (value !== "undefined") > > typeof value !== ... done.
Andrey Adaikin
Comment 4 2013-01-17 01:08:34 PST
Committed r139972: <http://trac.webkit.org/changeset/139972>
Note You need to log in before you can comment on or make changes to this bug.