Bug 107100

Summary: [EFL][WebGL] Fix Memory leaks in EGL and GLX surface.
Product: WebKit Reporter: Kalyan <kalyan.kondapally>
Component: WebKit EFLAssignee: Kalyan <kalyan.kondapally>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, laszlo.gombos, lucas.de.marchi, noam, ostap73, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch
none
patch
none
patch v3 none

Description Kalyan 2013-01-16 23:40:29 PST 
Some Issues:

1)We dont destroy the created FBO.
2)We dont free temp allocated XVisuals.
3)We close the XDisplay before surface and context are released.
Comment 1 Kalyan 2013-01-17 00:13:52 PST 
Created attachment 183131 [details]
patch
Comment 2 Kalyan 2013-01-17 07:43:48 PST 
Comment on attachment 183131 [details]
patch

Removing request for review. Will update a new patch without X changes as it will be handled in a separate changeset
Comment 3 Kalyan 2013-01-17 18:31:44 PST 
Created attachment 183343 [details]
patch
Comment 4 Viatcheslav Ostapenko 2013-01-17 20:02:21 PST 
Looks good to me.
Comment 5 Laszlo Gombos 2013-01-17 20:21:07 PST 
Comment on attachment 183343 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183343&action=review

Patch looks good to me as well. Please address the few nits.

> Source/WebCore/ChangeLog:8
> +        GLX and EGL surface dont release GL resources created by them.

nit: dont -> do not or don't

> Source/WebCore/ChangeLog:9
> +        This patch enusures that the leaks are fixed and

typo: enusures -> ensures

> Source/WebCore/ChangeLog:19
> +        (WebCore::GLXOffScreenContext::freeResources): Dont reset the display to null.

nit: Dont -> Don't
Comment 6 Kalyan 2013-01-17 20:39:19 PST 
Created attachment 183358 [details]
patch v3
Comment 7 Kalyan 2013-01-17 20:40:07 PST 
(In reply to comment #5)
> (From update of attachment 183343 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183343&action=review
> 
> nit: Dont -> Don't

done
Comment 8 Laszlo Gombos 2013-01-17 20:43:37 PST 
Comment on attachment 183358 [details]
patch v3

r=me.
Comment 9 WebKit Review Bot 2013-01-18 07:21:23 PST 
Comment on attachment 183358 [details]
patch v3

Clearing flags on attachment: 183358

Committed r140145: <http://trac.webkit.org/changeset/140145>
Comment 10 WebKit Review Bot 2013-01-18 07:21:27 PST 
All reviewed patches have been landed.  Closing bug.