Bug 107034

Summary: Get Windows test infrastructure to compile on VS2010 (32 bit)
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: PlatformAssignee: Roger Fong <roger_fong>
Severity: Normal CC: bfulgham, jonlee, roger_fong, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on: 106989    
Bug Blocks: 106949    
Description Flags
DRT and related projects
bfulgham: review+, bfulgham: commit-queue-
Last remaining test projects
Remaining test projects bfulgham: review+

Description Roger Fong 2013-01-16 10:31:22 PST
This includes testapi, testRegExp, WebCoreTestSupport, TestWebKitAPI, gtest-md, record-memory-win, TestNetscapePlugin, WebKitLauncherWin, ImageDiff, ImageDiffLauncher, DumpRenderTree, DumpRenderTree Launcher
Comment 1 Radar WebKit Bug Importer 2013-01-16 10:32:51 PST
Comment 2 Roger Fong 2013-02-07 16:45:13 PST
Created attachment 187199 [details]
DRT and related projects

This include DumpRenderTree and launcer, ImageDiff and launcher, WebCoreTestSupport and TestNetscapePlugin
Comment 3 Brent Fulgham 2013-02-07 21:50:36 PST
Comment on attachment 187199 [details]
DRT and related projects

View in context: https://bugs.webkit.org/attachment.cgi?id=187199&action=review

Looks great! I think you want to lose the *.users (and probably elsewhere in all the VS2010 stuff we've been playing with),

Also, I had a question about a file you deleted, that I hoped you could clarify in your ChangeLog entry.


> Source/WebCore/ChangeLog:10
> +        * WebCore.vcxproj/WebCoreTestSupport.vcxproj.user: Added.

I'm not sure we want to be checking in *.user files. I think it only contains user-specific stuff like break points and other stuff.

We should probably have them added to svn:ignore.

> Source/WebCore/WebCore.vcxproj/WebCoreTestSupport.vcxproj:52
> +      <DisableSpecificWarnings Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">4065;4273;4565;4701;4702;%(DisableSpecificWarnings)</DisableSpecificWarnings>

All of these targets use the same disabled warnings:  to the props file, please!

> Source/WebCore/WebCore.vcxproj/WebCoreTestSupport.vcxproj.user:3
> +</Project>

I don't think we ever want to add these to source control.

> Tools/ChangeLog:17
> +        * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj.user: Added.

Ditto my user comments from elsewhere.

> Tools/ChangeLog:30
> +        * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj.user: Added.


> Tools/ChangeLog:42
> +        * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.user: Added.


> Tools/ChangeLog:48
> +        * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Removed.

Why is this being deleted? Could you add a note, like maybe it's not used anymore or something?

> Tools/DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.user:3
> +</Project>

Delete please.

> Tools/DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj.user:4
> +    <LocalDebuggerCommandArguments>C:\cygwin\home\Roger\WebKit\OpenSource\LayoutTests\fast\js\kde</LocalDebuggerCommandArguments>

See! I don't want that for my build! :)

Delete from checking, please!

> Tools/DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj.user:3
> +</Project>

Delete this.

> Tools/DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj.user:3
> +</Project>

Delete please.

> Tools/DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.user:3
> +</Project>

Comment 4 Roger Fong 2013-02-07 23:59:36 PST
Ok, I'll do a mass svn delete of all the user files.

Also the file in question is a TestNetscapeAPI test that was in the wrong folder. I jsut moved it to the tests folder. I'll have to fix the VS2005 build when I land this.
Comment 5 Roger Fong 2013-02-08 11:44:12 PST
Committed with changes: http://trac.webkit.org/changeset/142303

I committed removing the .user files in a separate patch.
Comment 6 Roger Fong 2013-02-08 11:46:42 PST
I still have to do WebKitAPI, g-testmd, record-memory-win and WebKitLaunherWin
Comment 7 Roger Fong 2013-02-12 18:34:48 PST
Created attachment 187987 [details]
Last remaining test projects

gtest-md, testwebkitapi and record-memory
Also updates WebKit solution
Comment 8 Roger Fong 2013-02-13 12:34:13 PST
Created attachment 188147 [details]
Remaining test projects
Comment 9 Brent Fulgham 2013-02-13 13:03:56 PST
Comment on attachment 188147 [details]
Remaining test projects

Looks good to me.
Comment 10 Roger Fong 2013-02-13 13:43:52 PST
committed: http://trac.webkit.org/changeset/142785