Bug 107025

Summary: [gstreamer][cairo] GstBuffer memory is unmapped too soon in ImageGStreamer
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, menard, mrobinson, pnormand, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106551    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-01-16 09:54:19 PST
In the cairo implementation of ImageGStreamer, with gstreamer 1.0, the GstBuffer memory is mapped to construct a cairo_surface_t using cairo_image_surface_create_for_data() and then the buffer memory is unmapped right after. The documentation for cairo_image_surface_create_for_data() says that "The output buffer must be kept around until the cairo_surface_t is destroyed or cairo_surface_finish() is called on the surface." Unfortunately, the memory is unmapped while the image is still alive and the cairo_surface_t points internally to memory that is no longer valid. This may lead to crashes.
Attachments
Patch (5.89 KB, patch)
2013-01-16 10:00 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-01-16 10:00:22 PST
Created attachment 182998 [details] Patch
WebKit Review Bot
Comment 2 2013-01-16 10:45:43 PST
Comment on attachment 182998 [details] Patch Clearing flags on attachment: 182998 Committed r139896: <http://trac.webkit.org/changeset/139896>
WebKit Review Bot
Comment 3 2013-01-16 10:45:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.