Bug 107010

Summary: [CMake] Report actual values for feature configuration (instead of the default)
Product: WebKit Reporter: Hugo Parente Lima <hugo.lima>
Component: WebKit Misc.Assignee: Hugo Parente Lima <hugo.lima>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, laszlo.gombos, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Hugo Parente Lima
Reported 2013-01-16 06:56:29 PST
The features summary is printing the initial value instead of the value chosen by the user, so if you pass --no-svg to webkit-build script it's now showing ENABLE_SVG ON instead of ENABLE_SVG OFF.
Attachments
Patch (1.23 KB, patch)
2013-01-16 07:03 PST, Hugo Parente Lima 		no flags
DetailsFormatted DiffDiff
Patch (1.23 KB, patch)
2013-01-16 12:44 PST, Hugo Parente Lima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hugo Parente Lima
Comment 1 2013-01-16 07:03:24 PST
Created attachment 182978 [details] Patch
Laszlo Gombos
Comment 2 2013-01-16 09:58:08 PST
*** Bug 104738 has been marked as a duplicate of this bug. ***
Laszlo Gombos
Comment 3 2013-01-16 12:09:38 PST
Comment on attachment 182978 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182978&action=review > Source/cmake/WebKitFeatures.cmake:172 > - set(_MESSAGE "${_MESSAGE} ${_WEBKIT_AVAILABLE_OPTIONS_INITALVALUE_${_name}}") > + set(_MESSAGE "${_MESSAGE} ${${_name}}") Looks good. > ChangeLog:3 > + [cmake] Print the choose value on features summary instead of the initial value [cmake] -> [CMake] (to be consistent) choose --> chosen Perhaps - "[CMake] Report actual values for feature configuration (instead of the default)"
Hugo Parente Lima
Comment 4 2013-01-16 12:43:00 PST
(In reply to comment #3) > (From update of attachment 182978 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182978&action=review > > > Source/cmake/WebKitFeatures.cmake:172 > > - set(_MESSAGE "${_MESSAGE} ${_WEBKIT_AVAILABLE_OPTIONS_INITALVALUE_${_name}}") > > + set(_MESSAGE "${_MESSAGE} ${${_name}}") > > Looks good. > > > ChangeLog:3 > > + [cmake] Print the choose value on features summary instead of the initial value > > [cmake] -> [CMake] (to be consistent) > choose --> chosen > > Perhaps - "[CMake] Report actual values for feature configuration (instead of the default)" Yes, I noticed the typos after upload the patch, I'll re-upload it.
Hugo Parente Lima
Comment 5 2013-01-16 12:44:56 PST
Created attachment 183019 [details] Patch
Laszlo Gombos
Comment 6 2013-01-16 12:57:28 PST
Comment on attachment 183019 [details] Patch r=me.
WebKit Review Bot
Comment 7 2013-01-16 13:25:00 PST
Comment on attachment 183019 [details] Patch Clearing flags on attachment: 183019 Committed r139916: <http://trac.webkit.org/changeset/139916>
WebKit Review Bot
Comment 8 2013-01-16 13:25:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.