Bug 107000

Summary:

[EFL][WK2] Add API unit tests for ewk_pasteboard

Product:

WebKit

Reporter:

Michal Pakula vel Rutka <mpakulavelrutka>

Component:

WebKit2

Assignee:

Michal Pakula vel Rutka <mpakulavelrutka>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

gyuyoung.kim, mcatanzaro, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
patch	gyuyoung.kim: review-, eflews.bot: commit-queue-
fixes after review	none

Michal Pakula vel Rutka

Reported 2013-01-16 03:28:53 PST

According to EFL port policy new API has to be covered by API unit tests.

Attachments
patch (5.66 KB, patch) 2013-01-16 08:31 PST, Michal Pakula vel Rutka	gyuyoung.kim: review- eflews.bot: commit-queue-	Details Formatted Diff Diff
fixes after review (5.75 KB, patch) 2013-01-21 06:49 PST, Michal Pakula vel Rutka	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Michal Pakula vel Rutka

Comment 1 2013-01-16 08:31:00 PST

Created attachment 182989 [details] patch

EFL EWS Bot

Comment 2 2013-01-16 08:35:35 PST

Comment on attachment 182989 [details] patch Attachment 182989 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15901544

Gyuyoung Kim

Comment 3 2013-01-16 17:47:00 PST

Comment on attachment 182989 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=182989&action=review r- because of EFL bot build fail report. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_pasteboard.cpp:88 > + String pasteboardHTML = ASCIILiteral("<html><body><input type=\"text\" id=\"test\"></body></html>"); I don't like to use WebKit class in out of WebKit, if possible. Because it might to make unneeded dependency with WebKit. We have used const char* for a test html. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_pasteboard.cpp:99 > + ecore_main_loop_begin(); I wonder why you need to start ecore main loop whenever mouseClick is called.

Michal Pakula vel Rutka

Comment 4 2013-01-21 06:40:32 PST

Comment on attachment 182989 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=182989&action=review >> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_pasteboard.cpp:88 >> + String pasteboardHTML = ASCIILiteral("<html><body><input type=\"text\" id=\"test\"></body></html>"); > > I don't like to use WebKit class in out of WebKit, if possible. Because it might to make unneeded dependency with WebKit. We have used const char* for a test html. OK I will change it to const char*. >> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_pasteboard.cpp:99 >> + ecore_main_loop_begin(); > > I wonder why you need to start ecore main loop whenever mouseClick is called. Mouse events are sent asynchronously and test ends before context menu are called. I will remove the loops and set mouse events to synchronous.

Michal Pakula vel Rutka

Comment 5 2013-01-21 06:49:23 PST

Created attachment 183775 [details] fixes after review

Michael Catanzaro

Comment 6 2017-03-11 10:42:52 PST

Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.

Note You need to log in before you can comment on or make changes to this bug.