Bug 106964 – Add Chrome on Android instrumentation test types to flakiness dashboard

• Component: New Bugs
• Status: RESOLVED FIXED

[Frank Farzan]

The following test types will be added:

androidwebview_instrumentation_tests 
chromiumtestshell_instrumentation_tests 
contentshell_instrumentation_tests

I'll have a patch for this.

[Frank Farzan]

Created attachment 183229 [details]
Patch

[Ojan Vafai]

Comment on attachment 183229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183229&action=review

> Tools/ChangeLog:16
> +

Nit: extra line break.

> Tools/TestResultServer/generate_builders_json.py:108
> +        {'name': 'ChromiumFYI', 'url': 'http://build.chromium.org/p/chromium.fyi'},

As discussed offline, lets move this to a separate patch and update jsonp in that patch as well.

> Tools/TestResultServer/static-dashboards/builders.js:246
> +        // We don't have tests on ToT, but this must be included

This should be:
// FIXME: We don't have tests...

Ideally you'd also file a bug and list it in this comment. CC me and [e-mail].

[Frank Farzan]

Created attachment 183235 [details]
Patch

[Frank Farzan]

Created attachment 183241 [details]
Patch

[Frank Farzan]

Comment on attachment 183229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183229&action=review

>> Tools/ChangeLog:16
>> +
> 
> Nit: extra line break.

Removed.

>> Tools/TestResultServer/generate_builders_json.py:108
>> +        {'name': 'ChromiumFYI', 'url': 'http://build.chromium.org/p/chromium.fyi'},
> 
> As discussed offline, lets move this to a separate patch and update jsonp in that patch as well.

Done.

>> Tools/TestResultServer/static-dashboards/builders.js:246
>> +        // We don't have tests on ToT, but this must be included
> 
> This should be:
> // FIXME: We don't have tests...
> 
> Ideally you'd also file a bug and list it in this comment. CC me and [e-mail].

Done.

[Ojan Vafai]

Comment on attachment 183241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183241&action=review

> Tools/TestResultServer/static-dashboards/builders.js:249
> +        // FIXME: We don't have tests on ToT, but this must be included
> +        // since it's the default fall back when changing test types.
> +        // See https://bugs.webkit.org/show_bug.cgi?id=107155
> +        case '@ToT - chromium.org':

Julie is working on a fix for this. Should be fixed today or tomorrow. Lets just leave this out of this patch and it'll magically start working once her change goes in.

[Frank Farzan]

Created attachment 183338 [details]
Patch

[Frank Farzan]

Comment on attachment 183241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183241&action=review

>> Tools/TestResultServer/static-dashboards/builders.js:249
>> +        case '@ToT - chromium.org':
> 
> Julie is working on a fix for this. Should be fixed today or tomorrow. Lets just leave this out of this patch and it'll magically start working once her change goes in.

Done.

[Ojan Vafai]

Comment on attachment 183338 [details]
Patch

Julie's fix has been R+'ed as well.

[WebKit Review Bot]

Comment on attachment 183338 [details]
Patch

Rejecting attachment 183338 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 183338 [details]
Patch

Clearing flags on attachment: 183338

Committed r140092: <http://trac.webkit.org/changeset/140092>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.