Bug 106961

Summary: Add the ability for a RenderLayerBacking to have a layer that renders backgrounds.
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, dino, eric, ojan.autocc, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Description Simon Fraser (smfr) 2013-01-15 17:02:52 PST
Add the ability for a RenderLayerBacking to have a layer that renders backgrounds.
Comment 1 Simon Fraser (smfr) 2013-01-15 17:40:23 PST
Created attachment 182885 [details]
Patch
Comment 2 Dean Jackson 2013-01-15 17:58:02 PST
Comment on attachment 182885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182885&action=review

> Source/WebCore/ChangeLog:8
> +        In some cases we need a compositing layer to renders its background into

missing words near "to renders"

> Source/WebCore/rendering/RenderLayerBacking.cpp:759
> +        FloatSize backgroundSize = contentsSize;
> +        IntSize backgroundOffset = m_graphicsLayer->offsetFromRenderer();
> +        m_backgroundLayer->setPosition(FloatPoint());
> +        if (backgroundSize != m_backgroundLayer->size()) {
> +            m_backgroundLayer->setSize(backgroundSize);

Why do you need the local variable backgroundSize?
Comment 3 Simon Fraser (smfr) 2013-01-15 18:00:27 PST
(In reply to comment #2)
> > Source/WebCore/rendering/RenderLayerBacking.cpp:759
> > +        FloatSize backgroundSize = contentsSize;
> > +        IntSize backgroundOffset = m_graphicsLayer->offsetFromRenderer();
> > +        m_backgroundLayer->setPosition(FloatPoint());
> > +        if (backgroundSize != m_backgroundLayer->size()) {
> > +            m_backgroundLayer->setSize(backgroundSize);
> 
> Why do you need the local variable backgroundSize?

This will be used later!
Comment 4 Simon Fraser (smfr) 2013-01-15 18:03:24 PST
http://trac.webkit.org/changeset/139815