Bug 106961 – Add the ability for a RenderLayerBacking to have a layer that renders backgrounds.

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Add the ability for a RenderLayerBacking to have a layer that renders backgrounds.

[Simon Fraser (smfr)]

Created attachment 182885 [details]
Patch

[Dean Jackson]

Comment on attachment 182885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182885&action=review

> Source/WebCore/ChangeLog:8
> +        In some cases we need a compositing layer to renders its background into

missing words near "to renders"

> Source/WebCore/rendering/RenderLayerBacking.cpp:759
> +        FloatSize backgroundSize = contentsSize;
> +        IntSize backgroundOffset = m_graphicsLayer->offsetFromRenderer();
> +        m_backgroundLayer->setPosition(FloatPoint());
> +        if (backgroundSize != m_backgroundLayer->size()) {
> +            m_backgroundLayer->setSize(backgroundSize);

Why do you need the local variable backgroundSize?

[Simon Fraser (smfr)]

(In reply to comment #2)
> > Source/WebCore/rendering/RenderLayerBacking.cpp:759
> > +        FloatSize backgroundSize = contentsSize;
> > +        IntSize backgroundOffset = m_graphicsLayer->offsetFromRenderer();
> > +        m_backgroundLayer->setPosition(FloatPoint());
> > +        if (backgroundSize != m_backgroundLayer->size()) {
> > +            m_backgroundLayer->setSize(backgroundSize);
> 
> Why do you need the local variable backgroundSize?

This will be used later!

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/139815