Bug 106931

Summary: Table layout does not need to explicitly call computePreferredLogicalWidths
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, hyatt, jchaffraix, leviw, ojan.autocc, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Ojan Vafai
Reported 2013-01-15 11:32:06 PST
Table layout does not need to explicitly call computePreferredLogicalWidths
Attachments
Patch (7.56 KB, patch)
2013-01-15 11:35 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.23 KB, patch)
2013-01-17 12:18 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2013-01-15 11:35:46 PST
Created attachment 182816 [details] Patch
Julien Chaffraix
Comment 2 2013-01-16 14:53:58 PST
Comment on attachment 182816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182816&action=review > Source/WebCore/ChangeLog:28 > + * rendering/RenderTableCol.cpp: > + (WebCore::RenderTableCol::clearPreferredLogicalWidthsDirtyBits): > + * rendering/RenderTableCol.h: We should probably explain why this code is needed: columns (col) don't have the concept of preferred logical width but they rely on propagating the preferred logical widths bit up to the containing table if their style change.
Ojan Vafai
Comment 3 2013-01-17 12:18:51 PST
Created attachment 183242 [details] Patch for landing
WebKit Review Bot
Comment 4 2013-01-17 14:42:40 PST
Comment on attachment 183242 [details] Patch for landing Clearing flags on attachment: 183242 Committed r140047: <http://trac.webkit.org/changeset/140047>
WebKit Review Bot
Comment 5 2013-01-17 14:42:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.