Summary: | Table layout does not need to explicitly call computePreferredLogicalWidths | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||||
Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, hyatt, jchaffraix, leviw, ojan.autocc, tony, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ojan Vafai
2013-01-15 11:32:06 PST
Created attachment 182816 [details]
Patch
Comment on attachment 182816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182816&action=review > Source/WebCore/ChangeLog:28 > + * rendering/RenderTableCol.cpp: > + (WebCore::RenderTableCol::clearPreferredLogicalWidthsDirtyBits): > + * rendering/RenderTableCol.h: We should probably explain why this code is needed: columns (col) don't have the concept of preferred logical width but they rely on propagating the preferred logical widths bit up to the containing table if their style change. Created attachment 183242 [details]
Patch for landing
Comment on attachment 183242 [details] Patch for landing Clearing flags on attachment: 183242 Committed r140047: <http://trac.webkit.org/changeset/140047> All reviewed patches have been landed. Closing bug. |