| Summary: | New inspector/editor/text-editor-formatter.html introduced in r139617 fails on EFL, Mac, QT | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ádám Kallai <kadam> | ||||
| Component: | Tools / Tests | Assignee: | Andrey Lushnikov <lushnikov> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | d-r, gyuyoung.kim, kkristof, lushnikov, ossy, pfeldman, rakuco, szledan, webkit.review.bot, zan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 87008, 106705 | ||||||
| Attachments: |
|
||||||
Mac isn't an acronym. ;) Ohh, typo. Thanks. Created attachment 182728 [details]
Patch
It looks like it's already skipped on qt and mac, so I skip it on efl as well. Working on a fix. Comment on attachment 182728 [details]
Patch
I have landed it for you.
The related test(s) have been removed from trunk. |
This test fails: Diff is here: --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/editor/text-editor-formatter-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/editor/text-editor-formatter-actual.txt @@ -24,31 +24,8 @@ } } } +Uncaught exception in inspector front-end: ReferenceError: Can't find variable: textInputController [undefined:448] ============ editor contents start ============ -/** -*.Multi-line.comment -* -*/ -function.foo(n).{ -....//.one-line.comment -....function.bar().{ -........return.42; -....} -.... -....var.sum.=.0; -....for(var.i.=.0;.i.<.n;.++i).{ -........for(var.j.=.0;.j.<.n;.++j).{ -............sum.+=.i.+.j; -........} -....} -.... -.... -....if.(sum.>.1000).{ -........while.(sum.>.0).{ -............--sum; -........} -....} -} ============ editor contents end ============