Bug 106855

Summary: [Chromium] Speed up zoomed-offset-size.html after r139659
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: WebCore Misc.Assignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dominic Cooney
Reported 2013-01-14 19:03:23 PST
platform/chromium/virtual/deferred/fast/images/zoomed-offset-size.html started timing out on debug integration bugs around r139654-r139659. r139659 looks like a likely candidate. The test was marked slow in r139677. Emil, could you take a look at speeding up the test?
Attachments
Patch (47.05 KB, patch)
2013-01-15 10:18 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2013-01-15 09:55:13 PST
There is really no reason for that test to run for deferred image decoding, it is needed, however, for the regular image code path. Can we skip it? I'm not sure how the virtual tests works.
Levi Weintraub
Comment 2 2013-01-15 09:58:48 PST
I don't know much about the virtual tests either :( It can certainly be skipped just by being listed in the TestExpectations file with no expectations. In the meantime I've marked it as timing out in r139748.
Emil A Eklund
Comment 3 2013-01-15 10:03:17 PST
(In reply to comment #2) > I don't know much about the virtual tests either :( It can certainly be skipped just by being listed in the TestExpectations file with no expectations. In the meantime I've marked it as timing out in r139748. You've also marked fast/images/zoomed-offset-size.html as slow, is that really needed?
Levi Weintraub
Comment 4 2013-01-15 10:09:07 PST
Yes. It was timing out on numerous debug bots.
Emil A Eklund
Comment 5 2013-01-15 10:18:10 PST
Created attachment 182802 [details] Patch
Levi Weintraub
Comment 6 2013-01-15 10:18:47 PST
Comment on attachment 182802 [details] Patch LGTM.
Emil A Eklund
Comment 7 2013-01-15 10:23:34 PST
Committed r139753: <http://trac.webkit.org/changeset/139753>
Note You need to log in before you can comment on or make changes to this bug.