Bug 106812

Summary: [GStreamer] Fix indentation for GStreamer supported MIME types list
Product: WebKit Reporter: Adrian Perez <aperez>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, gustavo, menard, mrobinson, pnormand, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98759    
Attachments:
Description Flags
Patch
none
Patch none

Adrian Perez
Reported 2013-01-14 11:42:57 PST
[GTK] Fix indentation for GStreamer supported MIME types list
Attachments
Patch (7.48 KB, patch)
2013-01-14 11:49 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch (7.49 KB, patch)
2013-01-14 12:30 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2013-01-14 11:48:08 PST
Adding dependency.
Adrian Perez
Comment 2 2013-01-14 11:49:12 PST
Created attachment 182605 [details] Patch
Philippe Normand
Comment 3 2013-01-14 12:01:04 PST
Comment on attachment 182605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182605&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). You can remove this line.
Eric Carlson
Comment 4 2013-01-14 12:11:18 PST
Comment on attachment 182605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182605&action=review >> Source/WebCore/ChangeLog:8 >> + No new tests (OOPS!). > > You can remove this line. Yes, I think the commit-hook will reject the patch if you don't remove it.
Adrian Perez
Comment 5 2013-01-14 12:30:54 PST
Created attachment 182611 [details] Patch
Adrian Perez
Comment 6 2013-01-14 12:35:17 PST
(In reply to comment #3) > (From update of attachment 182605 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182605&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests (OOPS!). > > You can remove this line. Better, I have rewritten it as "No tests. No change in behavior." (like in other changelog entries).
WebKit Review Bot
Comment 7 2013-01-14 13:15:57 PST
Comment on attachment 182611 [details] Patch Clearing flags on attachment: 182611 Committed r139650: <http://trac.webkit.org/changeset/139650>
WebKit Review Bot
Comment 8 2013-01-14 13:16:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.