Bug 106724

Summary: If you use Phantom to force something to be live across an OSR exit, you should put it after the OSR exit
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 106690    
Attachments:
Description Flags
the patch oliver: review+

Filip Pizlo
Reported 2013-01-11 19:39:03 PST
In cases where we were getting it wrong, I think it was benign because we would either already have an OSR exit prior to there, or the operand would be a constant. But still, it's good to get this right.
Attachments
the patch (2.65 KB, patch)
2013-01-11 19:40 PST, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-01-11 19:40:03 PST
Created attachment 182456 [details] the patch
Filip Pizlo
Comment 2 2013-01-11 20:24:05 PST
Landed in http://trac.webkit.org/changeset/139540
Note You need to log in before you can comment on or make changes to this bug.