Summary: | Styling disappears from the cue that's being styled by ::cue pseudo element | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dima Gorbik <dgorbik> | ||||
Component: | Media | Assignee: | Dima Gorbik <dgorbik> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dgorbik, eric.carlson, feature-media-reviews, koivisto, ojan.autocc, rniwa, webkit-bug-importer, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dima Gorbik
2013-01-11 18:20:42 PST
Created attachment 182479 [details]
Proposed fix 0.1
Comment on attachment 182479 [details] Proposed fix 0.1 View in context: https://bugs.webkit.org/attachment.cgi?id=182479&action=review > Source/WebCore/html/track/TextTrackCue.cpp:661 > +void TextTrackCue::markFutureAndPastNodes(Node* root, double previousTimestamp, double movieTime) Could still be ContainerNode (In reply to comment #3) > (From update of attachment 182479 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182479&action=review > > > Source/WebCore/html/track/TextTrackCue.cpp:661 > > +void TextTrackCue::markFutureAndPastNodes(Node* root, double previousTimestamp, double movieTime) > > Could still be ContainerNode I will tighten this with the next patch. Thanks for a review! Comment on attachment 182479 [details] Proposed fix 0.1 Clearing flags on attachment: 182479 Committed r139562: <http://trac.webkit.org/changeset/139562> All reviewed patches have been landed. Closing bug. It appears that this test has been failing on WK2 bots since it was initially added: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=media%2Ftrack%2Ftrack-css-cue-lifetime.html I guess not necessarily on all WK2 bots but some. (In reply to comment #7) > It appears that this test has been failing on WK2 bots since it was initially added: > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=media%2Ftrack%2Ftrack-css-cue-lifetime.html Looks like this is happening because video seeking is much slower in WK2 for some reason. |