Bug 106676

Summary: [Chromium] unnecessary expectations in platform/chromium/accessibility
Product: WebKit Reporter: Dominic Mazzoni <dmazzoni>
Component: AccessibilityAssignee: Dominic Mazzoni <dmazzoni>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dpranke, eric.carlson, feature-media-reviews, jamesr, jdiggs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Dominic Mazzoni 2013-01-11 10:28:36 PST 
It looks like r131683 (http://trac.webkit.org/changeset/131683) copied a bunch of expectations files from platform/mac/accessibility to platform/chromium/accessibility, as part of this bug: https://bugs.webkit.org/show_bug.cgi?id=99666

Unfortunately, the majority of these were actually Mac-specific tests, not cross-platform tests - so having those expectations in platform/chromium/accessibility without any test file is just confusing.

In addition, some of the expectations that were copied were for tests that are currently skipped on Chromium - it also doesn't seem useful in that case.

Presumably the same mistake was made in other subdirectories, should we file some more bugs? I'm going to upload a cleanup patch for platform/chromium/accessibility since I'm pretty confident about what we need and don't need there, but we should consider similar logic elsewhere, unless I'm missing something.
Comment 1 Dominic Mazzoni 2013-01-11 10:45:14 PST 
Created attachment 182370 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-11 14:17:21 PST 
Comment on attachment 182370 [details]
Patch

Clearing flags on attachment: 182370

Committed r139495: <http://trac.webkit.org/changeset/139495>
Comment 3 WebKit Review Bot 2013-01-11 14:17:24 PST 
All reviewed patches have been landed.  Closing bug.