| Summary: | [CSS Filters] brightness() function doesn't work as specified | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Sierra <letmespellitoutforyou> | ||||||||||
| Component: | CSS | Assignee: | Dirk Schulze <krit> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | buildbot, cmarcelo, dglazkov, dino, eric.lemoine, eric, krit, macpherson, menard, ojan.autocc, rniwa, simon.fraser, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| URL: | https://github.com/mike-sierra/webplatform/blob/master/bugs/brightness.html | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 106808 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Mike Sierra
2013-01-11 09:50:32 PST
Additional behavior: brightness(-1) produces all black. *** Bug 105570 has been marked as a duplicate of this bug. *** The implementation sets the slope value to the default and modifies the intercept value, while it should be the other way around. WebKit is not following the specification here, but the specification is right. Created attachment 182486 [details]
patch for bots
Comment on attachment 182486 [details]
patch for bots
Why no test?
Comment on attachment 182486 [details] patch for bots Attachment 182486 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15868158 New failing tests: css3/filters/effect-combined.html css3/filters/effect-brightness-clamping.html css3/filters/multiple-filters-invalidation.html css3/filters/effect-brightness.html css3/filters/filter-property-parsing-invalid.html css3/filters/null-effect-check.html Comment on attachment 182486 [details] patch for bots Attachment 182486 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15853197 New failing tests: css3/filters/filter-property-parsing-invalid.html (In reply to comment #5) > (From update of attachment 182486 [details]) > Why no test? It is not for review. I had a compromised test folder and wanted to check on the bots. Looks like we have a lot of test covering brightness and I just need to adapt the test files. I'll upload a test for review. I confirmed with Photoshop that we would do the right thing with following the spec (which we don't right now). Created attachment 182488 [details]
Patch
Waiting for Chromium bot to know which pixel results need updates.
Comment on attachment 182488 [details] Patch Attachment 182488 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15874159 New failing tests: css3/filters/filter-property-parsing-invalid.html css3/filters/filter-property-parsing.html Comment on attachment 182488 [details] Patch Attachment 182488 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15838203 New failing tests: css3/filters/effect-brightness-hw.html css3/filters/effect-combined.html css3/filters/effect-brightness-clamping.html css3/filters/multiple-filters-invalidation.html css3/filters/effect-combined-hw.html css3/filters/effect-brightness.html css3/filters/filter-property-parsing-invalid.html css3/filters/effect-brightness-clamping-hw.html css3/filters/filter-property-parsing.html Created attachment 182492 [details]
Patch
Comment on attachment 182492 [details] Patch Attachment 182492 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15841248 New failing tests: css3/filters/filter-property-parsing.html Comment on attachment 182492 [details] Patch Attachment 182492 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15838233 New failing tests: css3/filters/filter-property-parsing.html Created attachment 182495 [details]
Patch
Chrome has a separate expected file that needs an update.
Comment on attachment 182495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182495&action=review I guess we should still have a test for values below 0 since we accept them. > LayoutTests/css3/filters/script-tests/filter-property-parsing.js:331 > +testFilterRule("Parameter less then -100%", Typo "than" > LayoutTests/css3/filters/script-tests/filter-property-parsing.js:336 > +testFilterRule("Parameter more then 100%", Ditto. Committed r139770: <http://trac.webkit.org/changeset/139770> |