Bug 106670

Summary: [GTK] Disable the unit tests timeout when running from make check
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, pnormand, webkit.review.bot, xan.lopez, zan
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Carlos Garcia Campos
Reported 2013-01-11 08:58:52 PST
The WebKit2 C API tests are always timing out for me, but the actually work. The problem is that the timeout was added when we had a different process per test, but the WebKit2 C API tests were merged into a single process. Bots are fast enough to run the WebKit C API tests in less than 10 secs, but my laptop isn't, so make distcheck is always failing for me. The timeout is very important in the bots, but when running make check you can manually finish the build that is going to fail anyway, so we can simply disable the timeout when running the test with make check.
Attachments
Patch (948 bytes, patch)
2013-01-11 09:01 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-01-11 09:01:17 PST
Created attachment 182352 [details] Patch
WebKit Review Bot
Comment 2 2013-01-11 09:29:35 PST
Comment on attachment 182352 [details] Patch Clearing flags on attachment: 182352 Committed r139453: <http://trac.webkit.org/changeset/139453>
WebKit Review Bot
Comment 3 2013-01-11 09:29:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.