Bug 106669 – [Qt] Switch to GStreamer 1.0

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Sebastian Dröge (slomo)]

+++ This bug was initially created as a clone of Bug #106085 +++

[Sebastian Dröge (slomo)]

Created attachment 182351 [details]
Switch QtWebKit to GStreamer 1.0

[WebKit Review Bot]

Attachment 182351 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Tools/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

Comment on attachment 182351 [details]
Switch QtWebKit to GStreamer 1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=182351&action=review

> Source/WebCore/WebCore.pri:169
> +    DEFINES += GST_API_VERSION=1.0

That one is not needed I think.

[Build Bot]

Comment on attachment 182351 [details]
Switch QtWebKit to GStreamer 1.0

Attachment 182351 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15809385

New failing tests:
svg/as-image/img-preserveAspectRatio-support-2.html

[Csaba Osztrogonác]

Why we need one more bug report for this bug?

[Csaba Osztrogonác]

Comment on attachment 182351 [details]
Switch QtWebKit to GStreamer 1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=182351&action=review

r=me with minor changes mentioned inline, but we should wait with landing until bots upgrade.

>> Source/WebCore/ChangeLog:9
>> +	Switch to GStreamer 1.0.
> 
> Line contains tab character.  [whitespace/tab] [5]

Please remove this line.

>> Source/WebCore/WebCore.pri:169
>> +    DEFINES += GST_API_VERSION=1.0
> 
> That one is not needed I think.

I agree, we don't need it.

>> Tools/ChangeLog:9
>> +	Switch to GStreamer 1.0.
> 
> Line contains tab character.  [whitespace/tab] [5]

Please remove this line.

[Csaba Osztrogonác]

*** Bug 106085 has been marked as a duplicate of this bug. ***

[Philippe Normand]

The code changed a bit since this patch was uploaded, a rebase will be needed I'm afraid.

[Csaba Osztrogonác]

(In reply to comment #8)
> The code changed a bit since this patch was uploaded, a rebase will be needed I'm afraid.

It applied and worked for me as is. ;)

[Philippe Normand]

Oh right, sorry I was confusing myself with Bug 106085 :)

[Allan Sandfeld Jensen]

Created attachment 190523 [details]
Patch

Updated version of Sebastian's patch, but including temporary support for gstreamer 0.10.

[Csaba Osztrogonác]

Comment on attachment 190523 [details]
Patch

LGTM, r=me. We can remove the temporary support later.

One little nit: Shouldn't we warn the developers if they still use 0.1 to 
install 1.0 as soon as possible, because 0.1 support will be dropped soon?

[Early Warning System Bot]

Comment on attachment 190523 [details]
Patch

Attachment 190523 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16768710

[Csaba Osztrogonác]

(In reply to comment #13)
> (From update of attachment 190523 [details])
> Attachment 190523 [details] did not pass qt-ews (qt):
> Output: http://webkit-commit-queue.appspot.com/results/16768710

Hmmm ... is it possible if it is an incremental build issue?

[Early Warning System Bot]

Comment on attachment 190523 [details]
Patch

Attachment 190523 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16666128

[Csaba Osztrogonác]

Ádám or Zoltán, could you test it with clean build on a machine with Gstreamer 1.0?

[Allan Sandfeld Jensen]

(In reply to comment #14)
> (In reply to comment #13)
> > (From update of attachment 190523 [details] [details])
> > Attachment 190523 [details] [details] did not pass qt-ews (qt):
> > Output: http://webkit-commit-queue.appspot.com/results/16768710
> 
> Hmmm ... is it possible if it is an incremental build issue?

Yes, it doesn't build incrementally when upgrading from 0.1 to 1.0. The problem is the flags are same since use_gstreamer now implies 1.0

[Csaba Osztrogonác]

Yes, it is incremental build issue, Zoltán checked it.

Unfortunately "maybe clean build needed" feature in webkitdris.pm isn't
perfect for EWS bots. But it will work on the buildbots, so it's safe
to land it now.

[WebKit Review Bot]

Comment on attachment 190523 [details]
Patch

Clearing flags on attachment: 190523

Committed r144208: <http://trac.webkit.org/changeset/144208>

[Philippe Normand]

Can this bug be closed now?

[Csaba Osztrogonác]

(In reply to comment #20)
> Can this bug be closed now?

Yes.