Bug 106660 – MediaStream API: Update the track accessors on MediaStream to match the latest specification

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Tommy Widenflycht]

MediaStream API: Update the track accessors on MediaStream to match the latest specification

[Tommy Widenflycht]

Created attachment 182333 [details]
Patch

[Tommy Widenflycht]

FYI the patch size is mostly deleted files and edited tests.

[kov's GTK+ EWS bot]

Comment on attachment 182333 [details]
Patch

Attachment 182333 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15803433

[Tommy Widenflycht]

Created attachment 182343 [details]
Patch

[Adam Barth]

Regressions: Unexpected text-only failures (1)
  webaudio/mediastreamaudiosourcenode.html [ Failure ]

[Adam Barth]

Comment on attachment 182343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182343&action=review

Looks great.  I wonder if there's one more test you need to update (based on the partial EWS results).

> Source/WebCore/ChangeLog:13
> +        In short: the attributes audioTrack/videoTrack that returned special MediaStreamTrackLists have been
> +        replaced by the functions getAudioTracks()/getVideoTracks that return standard sequences of
> +        MediaStreamTracks.

Great!

> Source/WebCore/Modules/mediastream/MediaStream.cpp:166
> +    default:
> +        ASSERT_NOT_REACHED();

We generally like to leave off the default and let the compiler tell us when we forget an enum value.

> Source/WebCore/Modules/mediastream/MediaStream.h:71
> +    DEFINE_ATTRIBUTE_EVENT_LISTENER(addtrack);
> +    DEFINE_ATTRIBUTE_EVENT_LISTENER(removetrack);

Should these be "trackadded" and "trackremoved" ?  Those names sound more like notifications.  (I'm sure you're just matching the spec here---this just jumped out at me.)

> Source/WebCore/Modules/mediastream/MediaStream.h:95
> +    // ContextDestructionObserver
> +    virtual void contextDestroyed();

OVERRIDE?

[WebKit Review Bot]

Comment on attachment 182343 [details]
Patch

Attachment 182343 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15811373

New failing tests:
webaudio/mediastreamaudiosourcenode.html

[WebKit Review Bot]

Comment on attachment 182343 [details]
Patch

Attachment 182343 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15811386

New failing tests:
webaudio/mediastreamaudiosourcenode.html

[Tommy Widenflycht]

Comment on attachment 182343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182343&action=review

>> Source/WebCore/ChangeLog:13
>> +        MediaStreamTracks.
> 
> Great!

Indeed!

>> Source/WebCore/Modules/mediastream/MediaStream.cpp:166
>> +        ASSERT_NOT_REACHED();
> 
> We generally like to leave off the default and let the compiler tell us when we forget an enum value.

Fixed.

>> Source/WebCore/Modules/mediastream/MediaStream.h:71
>> +    DEFINE_ATTRIBUTE_EVENT_LISTENER(removetrack);
> 
> Should these be "trackadded" and "trackremoved" ?  Those names sound more like notifications.  (I'm sure you're just matching the spec here---this just jumped out at me.)

You are right in both cases; the names is not 100% ok and I am matching the spec.

>> Source/WebCore/Modules/mediastream/MediaStream.h:95
>> +    virtual void contextDestroyed();
> 
> OVERRIDE?

Fixed.

[Tommy Widenflycht]

Created attachment 182528 [details]
Patch for landing

[Tommy Widenflycht]

Created attachment 182543 [details]
Patch for landing

[Tommy Widenflycht]

Patch updated for merge issues.

[WebKit Review Bot]

Comment on attachment 182543 [details]
Patch for landing

Clearing flags on attachment: 182543

Committed r139611: <http://trac.webkit.org/changeset/139611>