| Summary: | [chromium] move inspector related methods to TestRunner library | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||||
| Component: | New Bugs | Assignee: | jochen | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 91308 | ||||||||
| Attachments: |
|
||||||||
|
Description
jochen
2013-01-11 04:20:14 PST
Created attachment 182318 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 182318 [details]
Patch
ok
Comment on attachment 182318 [details]
Patch
setting to back to r? to wait for an API review
Comment on attachment 182318 [details]
Patch
LGTM2
Comment on attachment 182318 [details] Patch Rejecting attachment 182318 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ls/DumpRenderTree/chromium/TestRunner/src/TestRunner.h Hunk #1 succeeded at 289 (offset 8 lines). patching file Tools/DumpRenderTree/chromium/WebViewHost.cpp patching file Tools/DumpRenderTree/chromium/WebViewHost.h Hunk #1 FAILED at 150. 1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/chromium/WebViewHost.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15811385 Created attachment 182389 [details]
Patch for landing
Comment on attachment 182389 [details] Patch for landing Rejecting attachment 182389 [details] from commit-queue. New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Full output: http://queues.webkit.org/results/15815286 Comment on attachment 182389 [details] Patch for landing Clearing flags on attachment: 182389 Committed r139549: <http://trac.webkit.org/changeset/139549> All reviewed patches have been landed. Closing bug. |