Summary: | Web Inspector: fix DRT to deliver simulated events to devtools front-end | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Lushnikov <lushnikov> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Lushnikov <lushnikov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, jochen, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 106705 | ||||||||
Attachments: |
|
Description
Andrey Lushnikov
2013-01-11 03:03:10 PST
Created attachment 182312 [details]
Patch
Comment on attachment 182312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182312&action=review > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:77 > void setInterfaces(WebTestInterfaces*); I don't think you need this, just make interfaces private to the host and make it own it. > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:78 > + WebTestInterfaces *testInterfaces() const { return m_testInterfaces.get(); } WebTestInterfaces* > Tools/DumpRenderTree/chromium/TestShell.cpp:386 > + m_testRunner->setTestIsRunning(false); What if testRunner is missing? Can it be? > Tools/DumpRenderTree/chromium/TestShell.cpp:764 > + WebTestInterfaces * testInterfaces = new WebTestInterfaces(); Just move this into the host constructor. Comment on attachment 182312 [details] Patch I don't see an easy way how to achieve what you're trying to achieve there. Can you please post a design doc so we can discuss possible ways to fix this? View in context: https://bugs.webkit.org/attachment.cgi?id=182312&action=review > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:43 > +#include <wtf/OwnPtr.h> you can't have wtf/ headers in a public webkit api > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:137 > + OwnPtr<WebTestInterfaces> m_testInterfaces; there can only be one WebTestInterfaces class by design > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:183 > + virtual void reset() WebTestProxy should only have methods from WebFrameClient or WebViewClient > Tools/DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:-58 > - void setTestIsRunning(bool); why are you removing this? This is required for the frame load resource callback dumping et al >> Tools/DumpRenderTree/chromium/TestShell.cpp:386 >> + m_testRunner->setTestIsRunning(false); > > What if testRunner is missing? Can it be? we're going to delete DRTTestRunner soon, so please don't add new calls to it > Tools/DumpRenderTree/chromium/WebViewHost.cpp:-1171 > - proxy()->reset(); this won't work. WebTestProxy is also used by content::RenderViewImpl Created attachment 182330 [details]
Patch
Comment on attachment 182330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182330&action=review > Tools/DumpRenderTree/chromium/TestShell.cpp:751 > + m_devToolsTestInterfaces->bindTo(frame); ok, that might work. in content_shell, the devtools will run in their own process, and so they also get their own test interfaces. Keep in mind that this code (TestShell/DRT) is going to be deleted soon, so whatever you change here needs to be ported to content_shell Comment on attachment 182330 [details] Patch Clearing flags on attachment: 182330 Committed r139606: <http://trac.webkit.org/changeset/139606> All reviewed patches have been landed. Closing bug. |