Bug 106647

Summary:

CONFIG missing link_pkgconfig on Windows

Product:

WebKit

Reporter:

Jonathan Liu <net147>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, hausmann, vestbo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Jonathan Liu

Reported 2013-01-11 02:39:36 PST

Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link properly on Windows because they are added to PKGCONFIG but CONFIG does not contain link_pkgconfig. This is because link_pkgconfig is added in unix/default_pre.prf which is only used for UNIX platforms. To fix this, move it to the general default_pre.prf.

Attachments
Patch (2.31 KB, patch) 2013-01-11 02:42 PST, Jonathan Liu	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jonathan Liu

Comment 1 2013-01-11 02:42:54 PST

Created attachment 182304 [details] Patch

WebKit Review Bot

Comment 2 2013-01-13 09:19:25 PST

Comment on attachment 182304 [details] Patch Clearing flags on attachment: 182304 Committed r139570: <http://trac.webkit.org/changeset/139570>

WebKit Review Bot

Comment 3 2013-01-13 09:19:28 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.