Bug 106638 – AX: Computed hierarchical level is not consistent with aria-level

• Component: Accessibility
• Status: RESOLVED FIXED

[Dominic Mazzoni]

The specs for aria-level say that it's 1-based (http://www.w3.org/TR/wai-aria/states_and_properties#aria-level), but when no aria-level is provided, WebKit computes a 0-based hierarchical level for a tree, so they're inconsistent.

Mac uses 0-based levels, so I think the right solution is for WebKit to be 1-based internally (to match the aria-level spec) and the Mac impl should subtract one when returning disclosureLevel.

[Dominic Mazzoni]

Created attachment 182285 [details]
Patch

[Build Bot]

Comment on attachment 182285 [details]
Patch

Attachment 182285 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15806304

New failing tests:
platform/mac/accessibility/aria-treegrid.html

[Dominic Mazzoni]

Created attachment 182353 [details]
Patch

[chris fleizach]

Comment on attachment 182353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182353&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm:2484
> +            level -= 1;

it looks like you're not actually using level

[Dominic Mazzoni]

(In reply to comment #4)
> (From update of attachment 182353 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182353&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm:2484
> > +            level -= 1;
> 
> it looks like you're not actually using level

Oops, you're right.

[Dominic Mazzoni]

Created attachment 182356 [details]
Patch

[WebKit Review Bot]

Comment on attachment 182356 [details]
Patch

Clearing flags on attachment: 182356

Committed r139456: <http://trac.webkit.org/changeset/139456>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.