Bug 106628

Summary: Allow users to misspell the "sheriffs" command in sheriffbot
Product: WebKit Reporter: Alan Cutter <alancutter>
Component: Tools / TestsAssignee: Alan Cutter <alancutter>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, noel.gordon, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 106754    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Alan Cutter
Reported 2013-01-10 19:28:49 PST
Add aliases for the "sheriffs" command that cover the common misspellings that people make in sheriffbot. Misspellings: sherrifs, sherriffs, sherifs
Attachments
Patch (1.29 KB, patch)
2013-01-13 21:26 PST, Alan Cutter 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alan Cutter
Comment 1 2013-01-13 21:26:39 PST
Created attachment 182503 [details] Patch
noel gordon
Comment 2 2013-01-13 21:29:58 PST
GTLM :) Eric would say, "We might want to test this, but OK". Let's wait for his OK.
noel gordon
Comment 3 2013-01-13 21:31:49 PST
Just saw https:bug 106754
noel gordon
Comment 4 2013-01-13 22:04:38 PST
Ahem, bug 106754 so this LGTM.
Eric Seidel (no email)
Comment 5 2013-01-13 22:30:56 PST
Comment on attachment 182503 [details] Patch This is possibly the best patch I've seen this year. I can't spell sherrrifs to save my life.
Eric Seidel (no email)
Comment 6 2013-01-13 22:31:35 PST
Comment on attachment 182503 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182503&action=review > Tools/Scripts/webkitpy/tool/bot/irc_command.py:299 > +# Enough people misspell "sheriffs" that they've requested aliases for the command. > +commands["sherriffs"] = Sheriffs > +commands["sherifs"] = Sheriffs > +commands["sherrifs"] = Sheriffs This is also just a crutch for a "did you mean" behavior, but that's fine. We'll do that in SB 2.0 :)
WebKit Review Bot
Comment 7 2013-01-13 22:34:46 PST
Comment on attachment 182503 [details] Patch Clearing flags on attachment: 182503 Committed r139585: <http://trac.webkit.org/changeset/139585>
WebKit Review Bot
Comment 8 2013-01-13 22:34:50 PST
All reviewed patches have been landed. Closing bug.
Alan Cutter
Comment 9 2013-01-14 01:28:05 PST
(In reply to comment #5) > (From update of attachment 182503 [details]) > This is possibly the best patch I've seen this year. I can't spell sherrrifs to save my life. Hahaha. I'm very glad. (:
Note You need to log in before you can comment on or make changes to this bug.