Summary: | offsetWidth/height incorrect for images when zoomed | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||||||
Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, cmarcelo, dglazkov, eric, leviw, noel.gordon, ojan.autocc, ossy, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 106741 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Emil A Eklund
2013-01-10 18:19:14 PST
Created attachment 182236 [details]
Patch
Comment on attachment 182236 [details]
Patch
Missed a couple of LayoutTests that needs updating.
Created attachment 182438 [details]
Patch
Comment on attachment 182438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182438&action=review > LayoutTests/fast/images/zoomed-offset-size.html:6 > + zoom: 1.25; Can we iterate through a range of zoom levels? I'll feel more comfortable with that change :) Created attachment 182451 [details]
Patch
Comment on attachment 182451 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182451&action=review > LayoutTests/fast/images/zoomed-offset-size-expected.txt:1 > +PASS getSize(0.01).imageWidth is 250 That's probably more output than we need, but I like the completeness :) I feel good about this now. Comment on attachment 182451 [details] Patch Clearing flags on attachment: 182451 Committed r139537: <http://trac.webkit.org/changeset/139537> All reviewed patches have been landed. Closing bug. platform/chromium/inspector/styles/device-metrics-fit-window.html went red on chrome mac release with this change, expected? http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&group=%40ToT%20-%20webkit.org&tests=platform%2Fchromium%2Finspector%2Fstyles%2Fdevice-metrics-fit-window.html That looks looks like it just needs to be rebaselined. Emil, can you confirm? (In reply to comment #7) > (From update of attachment 182451 [details]) > Clearing flags on attachment: 182451 > > Committed r139537: <http://trac.webkit.org/changeset/139537> It made 2 tests fail on GTK/Qt/EFL - https://bugs.webkit.org/show_bug.cgi?id=106741 Could you check it, please? (In reply to comment #11) > (In reply to comment #7) > > (From update of attachment 182451 [details] [details]) > > Clearing flags on attachment: 182451 > > > > Committed r139537: <http://trac.webkit.org/changeset/139537> > > It made 2 tests fail on GTK/Qt/EFL - https://bugs.webkit.org/show_bug.cgi?id=106741 > > Could you check it, please? Those failures look legitimate. I'm going to roll this out until Emil can take a look. (In reply to comment #12) > > Those failures look legitimate. I'm going to roll this out until Emil can take a look. (I believe this is due to those ports not having sub-pixel layout enabled :( ) Reverted in http://trac.webkit.org/changeset/139573 Created attachment 182591 [details]
Patch
Comment on attachment 182591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182591&action=review > LayoutTests/fast/images/zoomed-offset-size.html:1 > +<!DOCTYPE html> You'll want to skip this test on GTK and Qt... sounds like EFL is turning this on today so maybe just let the folks doing that know :) Comment on attachment 182591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182591&action=review >> LayoutTests/fast/images/zoomed-offset-size.html:1 >> +<!DOCTYPE html> > > You'll want to skip this test on GTK and Qt... sounds like EFL is turning this on today so maybe just let the folks doing that know :) This test _should_ still work for non-subpixel ports. I'd like to leave it on for all ports for now and (quickly) disable it if my assumptions are incorrect if that is alright with you. (In reply to comment #17) > (From update of attachment 182591 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182591&action=review > > >> LayoutTests/fast/images/zoomed-offset-size.html:1 > >> +<!DOCTYPE html> > > > > You'll want to skip this test on GTK and Qt... sounds like EFL is turning this on today so maybe just let the folks doing that know :) > > This test _should_ still work for non-subpixel ports. I'd like to leave it on for all ports for now and (quickly) disable it if my assumptions are incorrect if that is alright with you. Sounds fine :) Comment on attachment 182591 [details] Patch Attachment 182591 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15884212 New failing tests: fast/frames/removal-before-attach-crash.html Comment on attachment 182591 [details] Patch Committed r139659: <http://trac.webkit.org/changeset/139659> |