Bug 106622

Summary: kill-old-processes and delete-stale-build-files use CRLF linebreaks
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dbates, dglazkov, eric, lforschler, rniwa, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes line breaks none

Simon Fraser (smfr)
Reported 2013-01-10 18:02:00 PST
The delete-stale-build-files script has Windows-style line breaks.
Attachments
Fixes line breaks (15.91 KB, patch)
2013-01-10 20:36 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-01-10 20:36:07 PST
Created attachment 182254 [details] Fixes line breaks
Eric Seidel (no email)
Comment 2 2013-01-10 21:11:38 PST
Isn't this solved by setting an svn prop?
WebKit Review Bot
Comment 3 2013-01-10 21:19:19 PST
Comment on attachment 182254 [details] Fixes line breaks Attachment 182254 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15801303 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Ryosuke Niwa
Comment 4 2013-01-10 21:25:57 PST
(In reply to comment #2) > Isn't this solved by setting an svn prop? Yes, that's an alternative.
Simon Fraser (smfr)
Comment 5 2013-01-10 22:06:27 PST
Comment on attachment 182254 [details] Fixes line breaks That flakey test needs fixing.
WebKit Review Bot
Comment 6 2013-01-10 22:24:13 PST
Comment on attachment 182254 [details] Fixes line breaks Clearing flags on attachment: 182254 Committed r139407: <http://trac.webkit.org/changeset/139407>
WebKit Review Bot
Comment 7 2013-01-10 22:24:16 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 8 2013-01-11 09:39:25 PST
This doesn't appear to have helped - I still have CRLF line breaks in kill-old-processes after an update on my Mac.
Ryosuke Niwa
Comment 9 2013-01-11 10:44:28 PST
Apparently commit-queue was being too smart here. Redid the CRLF-to-LF change in rhttp://trac.webkit.org/changeset/139460. It seemed to work for me.
Alexey Proskuryakov
Comment 10 2013-01-11 11:07:58 PST
Worked for me too, but I think that it will get reverted when someone edits the file from Windows. As Eric said, this needs an svn property to stick.
Ryosuke Niwa
Comment 11 2013-01-11 11:11:34 PST
(In reply to comment #10) > Worked for me too, but I think that it will get reverted when someone edits the file from Windows. As Eric said, this needs an svn property to stick. But other scripts in the same directory doesn't have svn property set either. I don't think we want to set svn property on all files?
Tony Chang
Comment 12 2013-01-11 13:27:13 PST
(In reply to comment #11) > (In reply to comment #10) > > Worked for me too, but I think that it will get reverted when someone edits the file from Windows. As Eric said, this needs an svn property to stick. > > But other scripts in the same directory doesn't have svn property set either. I don't think we want to set svn property on all files? It looks like it's already set on most files (try running svn pl * on a random WebCore subdir). This is mostly automatic if you have enable-auto-props=yes and an [auto-props] section in your ~/.subversion/config file. These scripts aren't getting an svn:eol-style set because they have no extension. Note that most of the files in Tools/Scripts also have svn:eol-style set to LF.
Tony Chang
Comment 13 2013-01-11 13:29:46 PST
(In reply to comment #12) > Note that most of the files in Tools/Scripts also have svn:eol-style set to LF. I lied, most of these have svn:executable set, not svn:eol-style. Maybe that also prevents line endings from converting on checkout.
Note You need to log in before you can comment on or make changes to this bug.