| Summary: | We should be able to checkpoint and restore the HTMLTokenizer across threads | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | buildbot, eric, ojan.autocc, rniwa, tonyg, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 106127 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Adam Barth
2013-01-10 13:48:42 PST
Created attachment 182199 [details]
Experiment---will need later
Created attachment 182200 [details]
Experiment---will need later
Created attachment 182231 [details]
Patch
Comment on attachment 182231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182231&action=review > Source/WebCore/html/parser/HTMLTokenizer.cpp:143 > + if (!m_appropriateEndTagName.isEmpty()) // Asserts because m_appropriateEndTagName is never cleared anywhere. We probably just need to clear it. We originally were very cheap about not clearing buffers in the tokenizer. Created attachment 182364 [details]
Patch
Comment on attachment 182364 [details] Patch Attachment 182364 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15804436 Created attachment 182369 [details]
Patch
Comment on attachment 182369 [details]
Patch
LGTM. Perhaps we should have Eric review the patch since we collaborated on writing it?
Comment on attachment 182369 [details]
Patch
Eric seems to be absorbed in threading code, so I'll review this patch.
Comment on attachment 182369 [details] Patch Clearing flags on attachment: 182369 Committed r139497: <http://trac.webkit.org/changeset/139497> All reviewed patches have been landed. Closing bug. |