|Summary:||We should be able to checkpoint and restore the HTMLTokenizer across threads|
|Product:||WebKit||Reporter:||Adam Barth <abarth>|
|Component:||New Bugs||Assignee:||Adam Barth <abarth>|
|Severity:||Normal||CC:||buildbot, eric, ojan.autocc, rniwa, tonyg, webkit.review.bot|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Adam Barth 2013-01-10 13:48:42 PST
We should be able to checkpoint and restore the HTMLTokenizer across threads
Comment 1 Adam Barth 2013-01-10 13:49:36 PST
Created attachment 182199 [details] Experiment---will need later
Comment 2 Adam Barth 2013-01-10 13:57:01 PST
Created attachment 182200 [details] Experiment---will need later
Comment 4 Adam Barth 2013-01-10 17:48:56 PST
Comment on attachment 182231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182231&action=review > Source/WebCore/html/parser/HTMLTokenizer.cpp:143 > + if (!m_appropriateEndTagName.isEmpty()) // Asserts because m_appropriateEndTagName is never cleared anywhere. We probably just need to clear it. We originally were very cheap about not clearing buffers in the tokenizer.
Comment 6 Build Bot 2013-01-11 10:38:05 PST
Comment on attachment 182364 [details] Patch Attachment 182364 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15804436
Comment 8 Adam Barth 2013-01-11 10:54:23 PST
Comment on attachment 182369 [details] Patch LGTM. Perhaps we should have Eric review the patch since we collaborated on writing it?
Comment 9 Adam Barth 2013-01-11 14:16:33 PST
Comment on attachment 182369 [details] Patch Eric seems to be absorbed in threading code, so I'll review this patch.
Comment 10 WebKit Review Bot 2013-01-11 14:21:37 PST
Comment on attachment 182369 [details] Patch Clearing flags on attachment: 182369 Committed r139497: <http://trac.webkit.org/changeset/139497>
Comment 11 WebKit Review Bot 2013-01-11 14:21:41 PST
All reviewed patches have been landed. Closing bug.