Bug 106538

Summary: Top layer fails for inline elements
Product: WebKit Reporter: Matt Falkenhagen <falken>
Component: Layout and RenderingAssignee: Matt Falkenhagen <falken>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, eric, esprehn, jchaffraix, macpherson, menard, ojan.autocc, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch for landing none

Matt Falkenhagen
Reported 2013-01-10 01:33:45 PST
When RenderLayer::rebuildZOrderLists traverses RenderView's children to collect top layer elements, it fails if a top layer element is inline, because it is wrapped in an anonymous block. So the following fails when dialog.showModal() is called: <body><dialog style="position:static"></body> I think this can be solved with a special child of RenderView that the top layer renderers are added to. This is probably cleaner for when we implement :backdrop as well.
Attachments
Patch (11.87 KB, patch)
2013-01-15 00:23 PST, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
patch for landing (11.89 KB, patch)
2013-01-17 00:59 PST, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Falkenhagen
Comment 1 2013-01-10 23:14:44 PST
Actually it seems top layer elements should never be in-flow. The spec says for a top layer element: "If its specified position property is static, it computes to absolute." There is no mention of 'relative', though. Shouldn't relative also compute to absolute? I'll write to WHATWG.
Matt Falkenhagen
Comment 2 2013-01-15 00:23:45 PST
Created attachment 182710 [details] Patch
Matt Falkenhagen
Comment 3 2013-01-15 00:25:28 PST
The Fullscreen spec has been updated to make clear that there are no in-flow elements in the top layer; 'static' and 'relative' compute to 'absolute'. I've uploaded a patch to do this.
Hajime Morrita
Comment 4 2013-01-17 00:44:47 PST
Comment on attachment 182710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182710&action=review > Source/WebCore/ChangeLog:12 > + anonymous block was added to the top layer. It's worth referring the spec section here.
Matt Falkenhagen
Comment 5 2013-01-17 00:59:37 PST
Created attachment 183138 [details] patch for landing
WebKit Review Bot
Comment 6 2013-01-17 17:35:55 PST
Comment on attachment 183138 [details] patch for landing Clearing flags on attachment: 183138 Committed r140075: <http://trac.webkit.org/changeset/140075>
WebKit Review Bot
Comment 7 2013-01-17 17:35:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.