Bug 106536

Summary: Changing tests to be consistent and use self.scm rather then recreating the scm object.
Product: WebKit Reporter: Tim 'mithro' Ansell <mithro>
Component: New BugsAssignee: Tim 'mithro' Ansell <mithro>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Tim 'mithro' Ansell
Reported 2013-01-10 00:51:57 PST
Changing tests to be consistent and use self.scm rather then recreating the scm object.
Attachments
Patch (21.67 KB, patch)
2013-01-10 00:52 PST, Tim 'mithro' Ansell 		no flags
DetailsFormatted DiffDiff
Patch (21.71 KB, patch)
2013-01-10 01:41 PST, Tim 'mithro' Ansell 		no flags
DetailsFormatted DiffDiff
Patch (21.86 KB, patch)
2013-01-10 02:03 PST, Tim 'mithro' Ansell 		no flags
DetailsFormatted DiffDiff
Patch (2.10 KB, patch)
2013-01-10 02:06 PST, Tim 'mithro' Ansell 		no flags
DetailsFormatted DiffDiff
Patch (5.10 KB, patch)
2013-01-10 02:32 PST, Tim 'mithro' Ansell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Tim 'mithro' Ansell
Comment 1 2013-01-10 00:52:53 PST
Created attachment 182081 [details] Patch
WebKit Review Bot
Comment 2 2013-01-10 00:57:17 PST
Attachment 182081 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2013-01-10 00:58:40 PST
Comment on attachment 182081 [details] Patch LGTM.
WebKit Review Bot
Comment 4 2013-01-10 01:14:56 PST
Comment on attachment 182081 [details] Patch Rejecting attachment 182081 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: rce/WebKit/chromium/webkit/media/crypto/ppapi/cdm --revision 173055 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 56>At revision 173055. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/15755923
Tim 'mithro' Ansell
Comment 5 2013-01-10 01:41:23 PST
Created attachment 182088 [details] Patch
Tim 'mithro' Ansell
Comment 6 2013-01-10 01:42:42 PST
Update the patch so it merges correctly.
Eric Seidel (no email)
Comment 7 2013-01-10 01:45:05 PST
Comment on attachment 182088 [details] Patch purple style bubbles don't bode well for this. purple normally means it failed to apply.
WebKit Review Bot
Comment 8 2013-01-10 01:59:43 PST
Comment on attachment 182088 [details] Patch Clearing flags on attachment: 182088 Committed r139299: <http://trac.webkit.org/changeset/139299>
WebKit Review Bot
Comment 9 2013-01-10 01:59:47 PST
All reviewed patches have been landed. Closing bug.
Tim 'mithro' Ansell
Comment 10 2013-01-10 02:03:00 PST
Reopening to attach new patch.
Tim 'mithro' Ansell
Comment 11 2013-01-10 02:03:05 PST
Created attachment 182093 [details] Patch
Tim 'mithro' Ansell
Comment 12 2013-01-10 02:06:36 PST
Created attachment 182094 [details] Patch
Eric Seidel (no email)
Comment 13 2013-01-10 02:07:19 PST
Comment on attachment 182094 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182094&action=review > Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1546 > - scm = detect_scm_system(self.git_checkout_path) > self._shared_test_exists(scm, scm.commit_locally_with_message) Doesn't look like this will wokr.
Tim 'mithro' Ansell
Comment 14 2013-01-10 02:32:24 PST
Created attachment 182097 [details] Patch
WebKit Review Bot
Comment 15 2013-01-10 10:42:25 PST
Comment on attachment 182097 [details] Patch Clearing flags on attachment: 182097 Committed r139338: <http://trac.webkit.org/changeset/139338>
WebKit Review Bot
Comment 16 2013-01-10 10:42:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.