Bug 106490

Summary: Allow live/local audio input to be enabled only when needed
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cdumez, dglazkov, eric.carlson, feature-media-reviews, fishd, fpizlo, jamesr, kbr, pnormand, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Rogers
Reported 2013-01-09 14:27:55 PST
Allow live/local audio input to be enabled only when needed
Attachments
Patch (18.57 KB, patch)
2013-01-09 14:42 PST, Chris Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2013-01-09 14:42:31 PST
Created attachment 181984 [details] Patch
WebKit Review Bot
Comment 2 2013-01-09 14:53:13 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Kenneth Russell
Comment 3 2013-01-09 15:55:03 PST
Comment on attachment 181984 [details] Patch The code changes look good to me though someone will have to approve the WebKit API changes.
Adam Barth
Comment 4 2013-01-09 16:34:45 PST
Comment on attachment 181984 [details] Patch API change LGTM
Kenneth Russell
Comment 5 2013-01-09 17:27:27 PST
Comment on attachment 181984 [details] Patch r=me
WebKit Review Bot
Comment 6 2013-01-09 17:42:07 PST
Comment on attachment 181984 [details] Patch Clearing flags on attachment: 181984 Committed r139262: <http://trac.webkit.org/changeset/139262>
WebKit Review Bot
Comment 7 2013-01-09 17:42:11 PST
All reviewed patches have been landed. Closing bug.
Filip Pizlo
Comment 8 2013-01-09 18:17:44 PST
Build fix landed in http://trac.webkit.org/changeset/139266
Chris Dumez
Comment 9 2013-01-09 23:00:44 PST
This patch broke the EFL Debug build: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug%20WK2/builds/7867/steps/compile-webkit/logs/stdio Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/dom/DeviceOrientationController.cpp.o [ 11%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/dom/Document.cpp.o /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp: In static member function ‘static WTF::PassOwnPtr<WebCore::AudioDestination> WebCore::AudioDestination::create(WebCore::AudioIOCallback&, unsigned int, unsigned int, float)’: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:48:17: error: ‘LOG_CHANNEL_PREFIXMedia’ was not declared in this scope /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:52:17: error: ‘LOG_CHANNEL_PREFIXMedia’ was not declared in this scope make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/platform/audio/gstreamer/AudioDestinationGStreamer.cpp.o] Error 1
Chris Dumez
Comment 10 2013-01-09 23:46:02 PST
Build fix for gstreamer backend landed in http://trac.webkit.org/changeset/139290.
Note You need to log in before you can comment on or make changes to this bug.