Bug 106448

Summary: Regression(r138681) : Add HAVE(ACCESSIBILITY) guard to atk files, fix for a fix.
Product: WebKit Reporter: Hugo Parente Lima <hugo.lima>
Component: AccessibilityAssignee: Hugo Parente Lima <hugo.lima>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, gyuyoung.kim, jdiggs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103162    
Attachments:
Description Flags
Patch none

Hugo Parente Lima
Reported 2013-01-09 06:07:01 PST
Some atk files don't use HAVE(ACCESSIBILITY). It may makes build errors when the macro isn't enabled, this was partially fixed by bug 106290, but in some files the include "atk.h" was left outside the guard.
Attachments
Patch (3.53 KB, patch)
2013-01-09 06:19 PST, Hugo Parente Lima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hugo Parente Lima
Comment 1 2013-01-09 06:19:17 PST
Created attachment 181911 [details] Patch
Gyuyoung Kim
Comment 2 2013-01-09 06:23:51 PST
Comment on attachment 181911 [details] Patch I missed this. Thanks.
WebKit Review Bot
Comment 3 2013-01-09 09:02:08 PST
Comment on attachment 181911 [details] Patch Clearing flags on attachment: 181911 Committed r139196: <http://trac.webkit.org/changeset/139196>
WebKit Review Bot
Comment 4 2013-01-09 09:02:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.