Bug 10644

Summary:

Add an embedabble KPart component for WebKit.

Product:

WebKit

Reporter:

Nikolas Zimmermann <zimmermann>

Component:

Platform

Assignee:

Nikolas Zimmermann <zimmermann>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Priority:

Version:

420+

Hardware:

Other

OS:

OS X 10.4

Attachments:

Description	Flags
General Frame adjustments	none
Remove QtLauncher	eric: review+
Adding WebKitPart.	darin: review+
DumpRenderTree adjustements	darin: review+
Update patch: General Frame adjustments	darin: review+
Move QtLauncher down to WebKitQt	timothy: review+

Nikolas Zimmermann

Reported 2006-08-30 14:57:08 PDT

Instead of the simple QtLauncher tool, we need a full-featured WebKitPart, which can be embedded in Konqueror for instance. Adding four patches soon: * A general patch which restructures FrameQt, to operate on FrameQtClient's just like Win/Mac platform code handles it. * Remove QtLauncher. * Adjust DumpRenderTree to the FrameQtClient code. * Add new WebKit/WebKitPart KDE component.

Attachments
General Frame adjustments (12.79 KB, patch) 2006-08-30 15:07 PDT, Nikolas Zimmermann	no flags	Details Formatted Diff Diff
Remove QtLauncher (4.97 KB, patch) 2006-08-30 15:08 PDT, Nikolas Zimmermann	eric: review+	Details Formatted Diff Diff
Adding WebKitPart. (28.17 KB, patch) 2006-08-30 15:09 PDT, Nikolas Zimmermann	darin: review+	Details Formatted Diff Diff
DumpRenderTree adjustements (8.14 KB, patch) 2006-08-30 15:10 PDT, Nikolas Zimmermann	darin: review+	Details Formatted Diff Diff
Update patch: General Frame adjustments (12.83 KB, patch) 2006-08-30 15:37 PDT, Nikolas Zimmermann	darin: review+	Details Formatted Diff Diff
Move QtLauncher down to WebKitQt (6.06 KB, patch) 2006-09-04 14:28 PDT, Nikolas Zimmermann	timothy: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Nikolas Zimmermann

Comment 1 2006-08-30 15:07:52 PDT

Created attachment 10323 [details] General Frame adjustments

Nikolas Zimmermann

Comment 2 2006-08-30 15:08:52 PDT

Created attachment 10324 [details] Remove QtLauncher

Nikolas Zimmermann

Comment 3 2006-08-30 15:09:27 PDT

Created attachment 10325 [details] Adding WebKitPart.

Nikolas Zimmermann

Comment 4 2006-08-30 15:10:05 PDT

Created attachment 10326 [details] DumpRenderTree adjustements

Eric Seidel (no email)

Comment 5 2006-08-30 15:13:56 PDT

Comment on attachment 10324 [details] Remove QtLauncher Looks fine.

Nikolas Zimmermann

Comment 6 2006-08-30 15:37:07 PDT

Created attachment 10327 [details] Update patch: General Frame adjustments Had a typo in the patch, updated.

Darin Adler

Comment 7 2006-09-03 12:17:13 PDT

Comment on attachment 10327 [details] Update patch: General Frame adjustments Looks good. This is an area that's changing a lot so it might be challenging to keep this compiling, but this is exactly the right direction, I believe.

Nikolas Zimmermann

Comment 8 2006-09-04 13:11:10 PDT

All has been landed by Sam Weinig, except the QtLauncher removal, as it will be moved to WebKitQt, too. (won't remove it)

Nikolas Zimmermann

Comment 9 2006-09-04 14:28:25 PDT

Created attachment 10395 [details] Move QtLauncher down to WebKitQt I changed my mind: QtLauncher is handy, and will be even more handy if we differentiate between Qt/KDE only builds.

Sam Weinig

Comment 10 2006-09-04 15:26:13 PDT

Patches landed in r16214, r16215, r16216 and r16219.

Note You need to log in before you can comment on or make changes to this bug.