Bug 10640

Summary: Auto-generate 10 more Objective-C DOM HTML bindings
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch
timothy: review-
patch 2 timothy: review+

Sam Weinig
Reported 2006-08-30 09:48:45 PDT
Splits out 10 more bindings. Actually only 9 of them are being auto-generated, (DOMHTMLBaseElement, DOMHTMLBodyElement, DOMHTMLHeadElement, DOMHTMLHtmlElement, DOMHTMLIsIndexElement, DOMHTMLLinkElement, DOMHTMLMetaElement, DOMHTMLStyleElement, DOMHTMLTitleElement) and DOMHTMLDocument has been split out into it's own file.
Attachments
patch (57.13 KB, patch)
2006-08-30 09:59 PDT, Sam Weinig 		timothy: review-
DetailsFormatted DiffDiff
patch 2 (57.95 KB, patch)
2006-08-30 11:10 PDT, Sam Weinig 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2006-08-30 09:59:20 PDT
Created attachment 10317 [details] patch
Timothy Hatcher
Comment 2 2006-08-30 10:45:15 PDT
Comment on attachment 10317 [details] patch This looks good.  One thing: +                push(@implContent, "    $exceptionInit\n"); +                push(@implContent, "    return $getterContent;\n"); +                push(@implContent, "    $exceptionRaiseOnError\n"); That will never raise on error, since the return happens first. Should $exceptionRaiseOnError be appended before return?
Timothy Hatcher
Comment 3 2006-08-30 10:46:37 PDT
Oh that wont work either. You will need a temp var to tell.
Sam Weinig
Comment 4 2006-08-30 11:10:45 PDT
Created attachment 10318 [details] patch 2 Addresses Tim's comments.
Timothy Hatcher
Comment 5 2006-08-30 11:27:38 PDT
Comment on attachment 10318 [details] patch 2 Looks good. You will need to merge with my recent change, adding headers to the "Copy Generated Headers" phase and marking them "project".
Sam Weinig
Comment 6 2006-08-31 19:08:24 PDT
Landed in r16125.
Note You need to log in before you can comment on or make changes to this bug.