Bug 106383

Summary:

ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views

Product:

WebKit

Reporter:

Levi Weintraub <leviw>

Component:

UI Events

Assignee:

Levi Weintraub <leviw>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, jamesr, simon.fraser, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

https://code.google.com/p/chromium/issues/detail?id=168001

Attachments:

Description	Flags
Patch	none

Description Levi Weintraub 2013-01-08 14:28:00 PST

We need to rects from nested views through convertToContainingView.

Comment 1 Levi Weintraub 2013-01-08 14:48:05 PST

Created attachment 181771 [details]
Patch

Comment 2 James Robinson 2013-01-09 21:58:18 PST

Comment on attachment 181771 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181771&action=review

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:188
> +        if (!r.isEmpty()) {

whole lotta' indentation here. can we get some early returns?

Comment 3 Levi Weintraub 2013-01-10 10:07:43 PST

Comment on attachment 181771 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181771&action=review

>> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:188
>> +        if (!r.isEmpty()) {
> 
> whole lotta' indentation here. can we get some early returns?

Good point. Done.

Comment 4 Levi Weintraub 2013-01-10 11:42:04 PST

Committed in http://trac.webkit.org/changeset/139346.