Bug 106372

Summary: [chromium] Define WebAnimationRegistrar
Product: WebKit Reporter: Ali Juma <ajuma>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, schenney, tkent+wkapi, vollick, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Define WebAnimationRegistrar jamesr: review-

Ali Juma
Reported 2013-01-08 13:26:45 PST
Created attachment 181744 [details] Define WebAnimationRegistrar This is needed for enabling accelerated animations for orphaned layers. See https://chromiumcodereview.appspot.com/11783037/ for the overall plan.
Attachments
Define WebAnimationRegistrar (2.37 KB, patch)
2013-01-08 13:26 PST, Ali Juma 		jamesr: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2013-01-08 13:30:42 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 2 2013-01-08 14:22:39 PST
Comment on attachment 181744 [details] Define WebAnimationRegistrar What does this do?
Ali Juma
Comment 3 2013-01-08 14:49:17 PST
(In reply to comment #2) > (From update of attachment 181744 [details]) > What does this do? The idea was to have an implementation WebAnimationRegistrarImpl in chromium that wraps a cc::AnimationRegistrar, giving us a way to get one layer's AnimationRegistrar and pass it to another layer.
James Robinson
Comment 4 2013-01-08 14:58:57 PST
Comment on attachment 181744 [details] Define WebAnimationRegistrar R- for no ChangeLog and the class not doing anything. I really doubt you need a new type in the WebKit API at all.
Adam Barth
Comment 5 2013-01-09 12:19:32 PST
I'm not sure if it's relevant here, but elsewhere in the API we use an "ExtraData" pattern to let the embedder associate arbitrary data with API objects.
Note You need to log in before you can comment on or make changes to this bug.