Bug 106366

Summary: [Skia] Implement GraphicsContext::fillRoundedRect() using SkCanvas::drawRRect()
Product: WebKit Reporter: Florin Malita <fmalita>
Component: Layout and RenderingAssignee: Florin Malita <fmalita>
Status: RESOLVED FIXED    
Severity: Normal CC: caryclark, dglazkov, eric.carlson, feature-media-reviews, junov, reed, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Florin Malita
Reported 2013-01-08 12:42:43 PST
Skia supports rounded rect draw commands, so there's no need to degrade fillRoundedRect() to drawPath().
Attachments
Patch (1.43 MB, patch)
2013-01-08 13:30 PST, Florin Malita 		no flags
DetailsFormatted DiffDiff
Patch (1.43 MB, patch)
2013-01-08 14:23 PST, Florin Malita 		no flags
DetailsFormatted DiffDiff
Patch (1.43 MB, patch)
2013-01-08 14:55 PST, Florin Malita 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.43 MB, patch)
2013-01-09 05:49 PST, Florin Malita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Florin Malita
Comment 1 2013-01-08 13:30:55 PST
Created attachment 181747 [details] Patch
Stephen White
Comment 2 2013-01-08 14:03:18 PST
Comment on attachment 181747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181747&action=review > Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:833 > + SkVector radii[4]; > + radii[SkRRect::kUpperLeft_Corner] = SkPoint::Make(topLeft.width(), topLeft.height()); > + radii[SkRRect::kUpperRight_Corner] = SkPoint::Make(topRight.width(), topRight.height()); > + radii[SkRRect::kLowerRight_Corner] = SkPoint::Make(bottomRight.width(), bottomRight.height()); > + radii[SkRRect::kLowerLeft_Corner] = SkPoint::Make(bottomLeft.width(), bottomLeft.height()); Looks a little strange to be assigning an SkPoint to an SkVector (even though they're the same thing). Since it's a typedef anyway, could you use SkVector::Make() here instead?
Florin Malita
Comment 3 2013-01-08 14:23:30 PST
Created attachment 181761 [details] Patch Thanks Stephen, updated.
Mike Reed
Comment 4 2013-01-08 14:31:23 PST
How about radii[SkRRect::kUpperLeft_Corner].set(topLeft.width(), topLeft.height()); ... No need to make and assign, when you can set. PS -- if we cared about warnings, we might want to promote width/height to floats (or SkScalars), since they are ints here. Not a request, just a note.
Florin Malita
Comment 5 2013-01-08 14:55:51 PST
Created attachment 181774 [details] Patch Updated, thanks Mike.
Stephen White
Comment 6 2013-01-08 14:57:09 PST
Comment on attachment 181774 [details] Patch Looks good. r=me
WebKit Review Bot
Comment 7 2013-01-08 18:03:14 PST
Comment on attachment 181774 [details] Patch Attachment 181774 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15771255 New failing tests: fast/forms/validation-message-appearance.html
Florin Malita
Comment 8 2013-01-09 05:49:04 PST
Created attachment 181902 [details] Patch for landing
WebKit Review Bot
Comment 9 2013-01-09 06:33:48 PST
Comment on attachment 181902 [details] Patch for landing Clearing flags on attachment: 181902 Committed r139191: <http://trac.webkit.org/changeset/139191>
WebKit Review Bot
Comment 10 2013-01-09 06:33:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.