Summary: | [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
Component: | Tools / Tests | Assignee: | Zan Dobersek <zan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, d-r, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Zan Dobersek
2013-01-08 11:18:12 PST
Created attachment 181721 [details]
Patch
Comment on attachment 181721 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181721&action=review Thanks. > Tools/Scripts/webkitpy/layout_tests/port/efl.py:-52 > def setup_test_run(self): > - self._unload_pulseaudio_module() Should this be calling super? (In reply to comment #2) > > Tools/Scripts/webkitpy/layout_tests/port/efl.py:-52 > > def setup_test_run(self): > > - self._unload_pulseaudio_module() > > Should this be calling super? That method in layout_tests.port.base.Port currently does nothing, but it's still probably a good idea to call it. https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py#L853 A new patch or can I just put the call in in this one? What works best for you? (In reply to comment #3) > (In reply to comment #2) > > > Tools/Scripts/webkitpy/layout_tests/port/efl.py:-52 > > > def setup_test_run(self): > > > - self._unload_pulseaudio_module() > > > > Should this be calling super? > > That method in layout_tests.port.base.Port currently does nothing, but it's still probably a good idea to call it. > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py#L853 > > A new patch or can I just put the call in in this one? What works best for you? Doesn't matter to me in the slightest. :) I'm happy to approve it either way. (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > > Tools/Scripts/webkitpy/layout_tests/port/efl.py:-52 > > > > def setup_test_run(self): > > > > - self._unload_pulseaudio_module() > > > > > > Should this be calling super? > > > > That method in layout_tests.port.base.Port currently does nothing, but it's still probably a good idea to call it. > > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py#L853 > > > > A new patch or can I just put the call in in this one? What works best for you? > > Doesn't matter to me in the slightest. :) I'm happy to approve it either way. The ChromiumPort interface behaves the same way, so a new patch is more appropriate. Comment on attachment 181721 [details] Patch Clearing flags on attachment: 181721 Committed r139095: <http://trac.webkit.org/changeset/139095> All reviewed patches have been landed. Closing bug. |