Bug 106348 – Plug-ins shouldn’t be added to list to autostart if you start a plugin in private browsing

• Component: Plug-ins
• Status: RESOLVED WONTFIX

[Brian Weinstein]

Plug-ins shouldn’t be added to list to autostart if you start a plugin in private browsing

<rdar://problem/12968442>

[Brian Weinstein]

Created attachment 181709 [details]
Fix

[Anders Carlsson]

Comment on attachment 181709 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=181709&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:271
> -    if (document()->page())
> +    if (document()->page() && document()->settings() && !document()->settings()->privateBrowsingEnabled())
>          document()->page()->plugInClient()->addAutoStartOrigin(document()->page()->mainFrame()->document()->baseURL().host(), m_plugInOriginHash);

I don't think you need to null check document()->settings() here since settings can only be null if page is null. I think this'd read better as

if (Page* page = document->page()) {
    if (!settings->privateBrowsingEnabled())
      page->plugInClient()-> etc etc
}

[Brian Weinstein]

Landed in http://trac.webkit.org/changeset/139096.

[WebKit Review Bot]

Re-opened since this is blocked by bug 106367