Bug 106341 – [GTK][WK2] accessibility/label-for-control-hittest.html is failing

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Zan Dobersek]

The accessibility/label-for-control-hittest.html layout test is failing on GTK WK2 port.

Here's the diff:
--- /home/zan/Dev/webkit/webkit/WebKitBuild/Release/layout-test-results/accessibility/label-for-control-hittest-expected.txt
+++ /home/zan/Dev/webkit/webkit/WebKitBuild/Release/layout-test-results/accessibility/label-for-control-hittest-actual.txt
@@ -4,7 +4,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS control.role is 'AXRole: AXCheckBox'
+FAIL control.role should be AXRole: AXCheckBox. Threw exception TypeError: 'null' is not an object (evaluating 'control.role')
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Krzysztof Czech]

Created attachment 194201 [details]
Patch

[Martin Robinson]

Comment on attachment 194201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194201&action=review

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:308
> +    return AccessibilityUIElement::create(atk_component_ref_accessible_at_point(ATK_COMPONENT(m_element), x, y, ATK_XY_WINDOW));

Just noticed that AccessibilityUIElement seems to be leaking every single element that it wraps. That seems unrelated though.

[Mario Sanchez Prada]

Comment on attachment 194201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194201&action=review

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:308
>> +    return AccessibilityUIElement::create(atk_component_ref_accessible_at_point(ATK_COMPONENT(m_element), x, y, ATK_XY_WINDOW));
> 
> Just noticed that AccessibilityUIElement seems to be leaking every single element that it wraps. That seems unrelated though.

Hmm... that's right. It seems we either would need to make PlatformUIElement a smart pointer or just to add some code in ~AccessibilityUIElement for ATK so we get rid of the reference to the AtkObject* owned by this class.

[Krzysztof Czech]

Created attachment 202405 [details]
Patch

[Krzysztof Czech]

AccessibilityUIElement::create(atk_component_ref_accessible_at_point(ATK_COMPONENT(m_element), x, y, ATK_XY_WINDOW));
> > 
> > Just noticed that AccessibilityUIElement seems to be leaking every single element that it wraps. That seems unrelated though.
> 
> Hmm... that's right. It seems we either would need to make PlatformUIElement a smart pointer or just to add some code in ~AccessibilityUIElement for ATK so we get rid of the reference to the AtkObject* owned by this class.

Patch correcting this failure has been proposed ( see 112913) and already landed.

[WebKit Commit Bot]

Comment on attachment 202405 [details]
Patch

Clearing flags on attachment: 202405

Committed r150439: <http://trac.webkit.org/changeset/150439>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.