Bug 106324

Summary: [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91308    
Attachments:
Description Flags
Patch none

jochen
Reported 2013-01-08 07:24:50 PST
[chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
Attachments
Patch (61.97 KB, patch)
2013-01-08 07:26 PST, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-01-08 07:26:20 PST
Created attachment 181690 [details] Patch
WebKit Review Bot
Comment 2 2013-01-08 07:27:43 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2013-01-08 11:21:55 PST
Comment on attachment 181690 [details] Patch It's slightly strange to smash the two client interfaces together into one object, but it doesn't seem harmful. If we run into a naming collision, we can refactor things.
jochen
Comment 4 2013-01-08 11:42:44 PST
(In reply to comment #3) > (From update of attachment 181690 [details]) > It's slightly strange to smash the two client interfaces together into one object, but it doesn't seem harmful. If we run into a naming collision, we can refactor things. Both RenderViewImpl and WebViewHost implement both interfaces..
WebKit Review Bot
Comment 5 2013-01-08 11:50:56 PST
Comment on attachment 181690 [details] Patch Clearing flags on attachment: 181690 Committed r139090: <http://trac.webkit.org/changeset/139090>
WebKit Review Bot
Comment 6 2013-01-08 11:51:00 PST
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 7 2013-01-08 12:47:36 PST
> Both RenderViewImpl and WebViewHost implement both interfaces.. Then there shouldn't be a problem down the line. :o)
Note You need to log in before you can comment on or make changes to this bug.