| Summary: | [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||
| Component: | New Bugs | Assignee: | jochen | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 91308 | ||||||
| Attachments: |
|
||||||
|
Description
jochen
2013-01-08 07:24:50 PST
Created attachment 181690 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 181690 [details]
Patch
It's slightly strange to smash the two client interfaces together into one object, but it doesn't seem harmful. If we run into a naming collision, we can refactor things.
(In reply to comment #3) > (From update of attachment 181690 [details]) > It's slightly strange to smash the two client interfaces together into one object, but it doesn't seem harmful. If we run into a naming collision, we can refactor things. Both RenderViewImpl and WebViewHost implement both interfaces.. Comment on attachment 181690 [details] Patch Clearing flags on attachment: 181690 Committed r139090: <http://trac.webkit.org/changeset/139090> All reviewed patches have been landed. Closing bug. > Both RenderViewImpl and WebViewHost implement both interfaces..
Then there shouldn't be a problem down the line. :o)
|