Bug 106312

Summary: [Chromium] Hiding popups on mouse wheel should be handled by WebViewImpl
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keishi Hattori
Reported 2013-01-08 01:35:29 PST
We had to removed the code that closed popups on mouse wheel events from content::RenderWidgetHostViewMac because we no longer had access to child popups. This should be handled by WebViewImpl. https://src.chromium.org/viewvc/chrome?view=rev&revision=175488
Attachments
Patch (2.67 KB, patch)
2013-01-08 01:48 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2013-01-08 01:48:23 PST
Created attachment 181672 [details] Patch
Kent Tamura
Comment 2 2013-01-08 01:58:00 PST
Comment on attachment 181672 [details] Patch looks good
WebKit Review Bot
Comment 3 2013-01-08 02:56:05 PST
Comment on attachment 181672 [details] Patch Rejecting attachment 181672 [details] from commit-queue. New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Full output: http://queues.webkit.org/results/15755125
WebKit Review Bot
Comment 4 2013-01-08 17:42:35 PST
Comment on attachment 181672 [details] Patch Clearing flags on attachment: 181672 Committed r139139: <http://trac.webkit.org/changeset/139139>
WebKit Review Bot
Comment 5 2013-01-08 17:42:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.