Summary: | [Chromium] Cannot copy text when selecting readonly (or disabled) input elements | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shinya Kawanaka <shinyak> | ||||||||||||||||
Component: | HTML Editing | Assignee: | Shinya Kawanaka <shinyak> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | dglazkov, mifenton, morrita, peter+ews, philn, tkent, webcomponents-bugzilla, webkit.review.bot, xan.lopez | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Shinya Kawanaka
2013-01-07 18:27:00 PST
Created attachment 181620 [details]
Patch
Comment on attachment 181620 [details] Patch Attachment 181620 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15736950 Comment on attachment 181620 [details] Patch Attachment 181620 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15738967 Comment on attachment 181620 [details] Patch Attachment 181620 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15734946 Created attachment 181829 [details]
Build Test
Comment on attachment 181829 [details] Build Test Attachment 181829 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15757376 Created attachment 181842 [details]
Build Test
Created attachment 181852 [details]
Patch
Comment on attachment 181852 [details]
Patch
Can we make the tests LayoutTest?
Comment on attachment 181852 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181852&action=review I am not a reviewer, but I have two comments and a question inline. > Source/WebCore/ChangeLog:3 > + [Chromium] Cannot copy text when selecting readonly (or disable) input elements. disable => disabled > Source/WebCore/ChangeLog:13 > + We should use ShadowRoot instead of document so that we can stay in the same tree scope. Nice explanation of the issue. > Source/WebCore/editing/FrameSelection.h:138 > Element* rootEditableElementOrDocumentElement() const; What is your opinion about this method? It has many callers. Are they all likely to need updating? (Not in this patch, of course.) Comment on attachment 181852 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181852&action=review >> Source/WebCore/editing/FrameSelection.h:138 >> Element* rootEditableElementOrDocumentElement() const; > > What is your opinion about this method? It has many callers. Are they all likely to need updating? (Not in this patch, of course.) Basically they should be updated. Created attachment 185129 [details]
Patch
Comment on attachment 185129 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185129&action=review > Source/WebKit/chromium/tests/WebViewTest.cpp:694 > + EXPECT_EQ(length, 29UL); Let's do some strlen()-like thing for explaining the magic number. Created attachment 185131 [details]
Patch
Comment on attachment 185131 [details] Patch Attachment 185131 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16163910 Created attachment 185146 [details]
Patch for landing
Waiting for bots green Comment on attachment 185146 [details] Patch for landing Clearing flags on attachment: 185146 Committed r141196: <http://trac.webkit.org/changeset/141196> All reviewed patches have been landed. Closing bug. |