| Summary: | HTMLTreeBuilder shouldn't keep a Document pointer | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 106127 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Barth
2013-01-07 15:39:48 PST
Created attachment 181579 [details]
Patch
Comment on attachment 181579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181579&action=review > Source/WebCore/html/parser/HTMLTreeBuilder.cpp:326 > + m_isAttached = false; This appears to be a debug-only flag? > Source/WebCore/html/parser/HTMLTreeBuilder.cpp:826 > - if (!m_document->inQuirksMode() && m_tree.openElements()->inButtonScope(pTag)) > + if (!m_tree.inQuirksMode() && m_tree.openElements()->inButtonScope(pTag)) I really like this change. (In reply to comment #2) > (From update of attachment 181579 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181579&action=review > > > Source/WebCore/html/parser/HTMLTreeBuilder.cpp:326 > > + m_isAttached = false; > > This appears to be a debug-only flag? Yes! It is now. I'll mark it as such. > > Source/WebCore/html/parser/HTMLTreeBuilder.cpp:826 > > - if (!m_document->inQuirksMode() && m_tree.openElements()->inButtonScope(pTag)) > > + if (!m_tree.inQuirksMode() && m_tree.openElements()->inButtonScope(pTag)) > > I really like this change. Thanks! Created attachment 181654 [details]
Patch for landing
Comment on attachment 181654 [details] Patch for landing Clearing flags on attachment: 181654 Committed r139042: <http://trac.webkit.org/changeset/139042> All reviewed patches have been landed. Closing bug. |