Bug 106235
| Summary: | webkit-patch rebaseline-expectations spits out tons of lint warnings | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, dpranke, eric, tony |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ojan Vafai
It should only spit out warnings about the lines that have "Rebaseline" modifiers. Right now it gives a bunch of spew about unrelated lines.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ojan Vafai
There's so much right now that I can't tell if it succeeded or not. I see some python backtraces as well. :(
Traceback (most recent call last):
File "/work/chromium/src/third_party/WebKit/Tools/Scripts/webkit-patch", line 84, in <module>
main()
File "/work/chromium/src/third_party/WebKit/Tools/Scripts/webkit-patch", line 79, in main
WebKitPatch(os.path.abspath(__file__)).main()
File "/work/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 313, in main
result = command.check_arguments_and_execute(options, args, self)
File "/work/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 122, in check_arguments_and_execute
return self.execute(options, args, tool) or 0
File "/work/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 196, in execute
self._rebaseline_test_and_update_expectations(options)
File "/work/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 189, in _rebaseline_test_and_update_expectations
results_url = self._results_url(options.builder)
File "/work/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 91, in _results_url
return self._tool.buildbot_for_builder_name(builder_name).builder_with_name(builder_name).latest_layout_test_results_url()
File "/work/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 70, in latest_layout_test_results_url
return self.accumulated_results_url() or self.latest_cached_build().results_url();
File "/work/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 123, in latest_cached_build
revision_build_pairs = self.revision_build_pairs_with_results()
File "/work/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 182, in revision_build_pairs_with_results
return self._revision_to_build_map().items()
File "/work/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 178, in _revision_to_build_map
self._revision_to_build_number = self._fetch_revision_to_build_map()
File "/work/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 159, in _fetch_revision_to_build_map
result_files = self._buildbot._fetch_twisted_directory_listing(self.results_url())
File "/work/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 401, in _fetch_twisted_directory_listing
return self._parse_twisted_directory_listing(urllib2.urlopen(url))
File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
return _opener.open(url, data, timeout)
File "/usr/lib/python2.7/urllib2.py", line 406, in open
response = meth(req, response)
File "/usr/lib/python2.7/urllib2.py", line 519, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib/python2.7/urllib2.py", line 438, in error
result = self._call_chain(*args)
File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 625, in http_error_302
return self.parent.open(new, timeout=req.timeout)
File "/usr/lib/python2.7/urllib2.py", line 406, in open
response = meth(req, response)
File "/usr/lib/python2.7/urllib2.py", line 519, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib/python2.7/urllib2.py", line 444, in error
return self._call_chain(*args)
File "/usr/lib/python2.7/urllib2.py", line 378, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 527, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 502: Proxy Error
Ojan Vafai
BTW, I was synced to r138963 and ran "webkit-patch rebaseline-expectations" with a Rebaseline modifier for all the Bug(ojan) lines in the gtk, qt, mac and chromium TestExpectations files. It appears only the Chromium rebaselines actually succeeded. I've since gone through and done the other rebaselines with garden-o-matic.