Summary: | Web Inspector: Refactor InspectorTest to create output interface | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | johnjbarton <johnjbarton> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, dglazkov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
johnjbarton
2013-01-07 10:22:59 PST
Created attachment 181523 [details]
Patch
Hmm, the patch is hard to read, let me know if you want the re-indent separate. Comment on attachment 181523 [details] Patch Attachment 181523 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15731857 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html (In reply to comment #3) > New failing tests: > inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Passes for me on linux. output says DumpRenderTree crashed? Comment on attachment 181523 [details]
Patch
We don't really indent within the namespaces to save some horizontal space. Could you split (or drop) the formatting and upload the refactoring changes only? Otherwise it is really hard to follow them.
Created attachment 181959 [details]
Patch
Re-indent removed to bug 106475 Comment on attachment 181959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181959&action=review > LayoutTests/http/tests/inspector/inspector-test.js:20 > + addResult: function(text) Please add blank line between methods. Created attachment 182154 [details]
Patch
Comment on attachment 182154 [details] Patch Clearing flags on attachment: 182154 Committed r139332: <http://trac.webkit.org/changeset/139332> All reviewed patches have been landed. Closing bug. |