Bug 106217

Summary: [Qt] Webkit debug builds links against release binaries of ANGLE libEGL, libGLESv2
Product: WebKit Reporter: Kai Koehne <kai.koehne>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, jturcotte, michael.bruning, net147, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch fixing debug only compilation jturcotte: review+

Kai Koehne
Reported 2013-01-07 06:59:32 PST
When angle is compiled in QtBase both debug and release versions of libEGL[d], libGLESv2[d] are created. However, webkit always links against the release versions, even for the debug build.
Attachments
Patch fixing debug only compilation (1.43 KB, patch)
2013-01-07 07:05 PST, Kai Koehne 		jturcotte: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kai Koehne
Comment 1 2013-01-07 07:05:05 PST
Created attachment 181503 [details] Patch fixing debug only compilation
Kai Koehne
Comment 2 2013-01-23 01:54:15 PST
WIthout this patch all 'pure debug' builds of Qt on windows will fail to link. Can we please get this reviewed?
Kai Koehne
Comment 3 2013-01-23 02:04:59 PST
... and preferably merged into the 'release' branch :)
Kai Koehne
Comment 4 2013-01-23 23:45:40 PST
This reportedly fixes crashes too: Even if linking succeeds due to release dlls being available, we'll load both debug and release libs of the libEGL, libGLESv2 into memory at runtime.
Jocelyn Turcotte
Comment 5 2013-01-24 03:11:39 PST
Comment on attachment 181503 [details] Patch fixing debug only compilation Arf, I saw that bug before but I assumed that the bug was in Qt... Thanks for the fix, I'll pick it in the 5.0.x branch once it landed.
WebKit Review Bot
Comment 6 2013-01-24 03:22:24 PST
Comment on attachment 181503 [details] Patch fixing debug only compilation Rejecting attachment 181503 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 181503, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Jocelyn Turcotte']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patch: **** Can't create file /tmp/pp8rM352 : No space left on device patch: **** Can't create file /tmp/ppPs7OY3 : No space left on device Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Jocelyn Turcotte']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16079646
Michael Brüning
Comment 7 2013-01-24 04:21:28 PST
Committed r140675: <http://trac.webkit.org/changeset/140675>
Note You need to log in before you can comment on or make changes to this bug.