| Summary: | [Track] Rendering crash | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Victor Carbune <vcarbune> | ||||||
| Component: | Media | Assignee: | Victor Carbune <vcarbune> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric.carlson, feature-media-reviews, ojan.autocc, silviapf, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 525.x (Safari 3.2) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 181466 [details]
Track added through JS
Created attachment 181518 [details]
Patch
Comment on attachment 181518 [details]
Patch
Thanks!
Comment on attachment 181518 [details] Patch Clearing flags on attachment: 181518 Committed r138966: <http://trac.webkit.org/changeset/138966> All reviewed patches have been landed. Closing bug. |
I'm currently still looking at what recent changes might have generated this assertion fail (basically the first child is not necessarily inline rendered). #0 0x00007f81c0dde895 in WebCore::toRenderInline (object=0x7f81ac5c5eb8) at ../../third_party/WebKit/Source/WebCore/rendering/RenderInline.h:191 #1 0x00007f81c101ef63 in WebCore::RenderTextTrackCue::initializeLayoutParameters (this=0x7f81aca7ee18, firstLineBox=@0x7fff6049e4e0, step=..., position=...) at ../../third_party/WebKit/Source/WebCore/rendering/RenderTextTrackCue.cpp:60 #2 0x00007f81c101edce in WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet (this=0x7f81aca7ee18) at ../../third_party/WebKit/Source/WebCore/rendering/RenderTextTrackCue.cpp:203 #3 0x00007f81c101ed5f in WebCore::RenderTextTrackCue::layout (this=0x7f81aca7ee18) at ../../third_party/WebKit/Source/WebCore/rendering/RenderTextTrackCue.cpp:49 #4 0x00007f81c0dbf156 in WebCore::RenderObject::layoutIfNeeded (this=0x7f81aca7ee18) at ../../third_party/WebKit/Source/WebCore/rendering/RenderObject.h:675 #5 0x00007f81c0e02c11 in WebCore::RenderBlock::layoutPositionedObjects (this=0x7f81ac2b6698, relayoutChildren=true) at ../../third_party/WebKit/Source/WebCore/rendering/RenderBlock.cpp:2646 #6 0x00007f81c0e002ea in WebCore::RenderBlock::layoutBlock (this=0x7f81ac2b6698, relayoutChildren=true, pageLogicalHeight=...) [...]