Bug 106195

Summary: [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Zan Dobersek 2013-01-06 12:12:44 PST 
[GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
Comment 1 Zan Dobersek 2013-01-06 12:21:53 PST 
Created attachment 181463 [details]
Patch
Comment 2 Philippe Normand 2013-01-07 08:29:09 PST 
Comment on attachment 181463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181463&action=review

> Tools/gtk/gtkdoc.py:188
> +        stdout, stderr = map(lambda b: b.decode("utf-8"), process.communicate())

Wouldn't a list comprehension work here? I find those easier to deal with than map/lambda
Comment 3 Zan Dobersek 2013-01-07 11:52:16 PST 
Created attachment 181538 [details]
Patch
Comment 4 Zan Dobersek 2013-01-07 11:52:44 PST 
(In reply to comment #2)
> (From update of attachment 181463 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181463&action=review
> 
> > Tools/gtk/gtkdoc.py:188
> > +        stdout, stderr = map(lambda b: b.decode("utf-8"), process.communicate())
> 
> Wouldn't a list comprehension work here? I find those easier to deal with than map/lambda

You're right, that approach is clearer.
Comment 5 Zan Dobersek 2013-01-08 02:11:37 PST 
Comment on attachment 181538 [details]
Patch

Clearing flags on attachment: 181538

Committed r139048: <http://trac.webkit.org/changeset/139048>
Comment 6 Zan Dobersek 2013-01-08 02:11:45 PST 
All reviewed patches have been landed.  Closing bug.