Bug 106195

Summary: [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2013-01-06 12:12:44 PST
[GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
Attachments
Patch (5.57 KB, patch)
2013-01-06 12:21 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (5.53 KB, patch)
2013-01-07 11:52 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-01-06 12:21:53 PST
Created attachment 181463 [details] Patch
Philippe Normand
Comment 2 2013-01-07 08:29:09 PST
Comment on attachment 181463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181463&action=review > Tools/gtk/gtkdoc.py:188 > + stdout, stderr = map(lambda b: b.decode("utf-8"), process.communicate()) Wouldn't a list comprehension work here? I find those easier to deal with than map/lambda
Zan Dobersek
Comment 3 2013-01-07 11:52:16 PST
Created attachment 181538 [details] Patch
Zan Dobersek
Comment 4 2013-01-07 11:52:44 PST
(In reply to comment #2) > (From update of attachment 181463 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181463&action=review > > > Tools/gtk/gtkdoc.py:188 > > + stdout, stderr = map(lambda b: b.decode("utf-8"), process.communicate()) > > Wouldn't a list comprehension work here? I find those easier to deal with than map/lambda You're right, that approach is clearer.
Zan Dobersek
Comment 5 2013-01-08 02:11:37 PST
Comment on attachment 181538 [details] Patch Clearing flags on attachment: 181538 Committed r139048: <http://trac.webkit.org/changeset/139048>
Zan Dobersek
Comment 6 2013-01-08 02:11:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.