Bug 106169

Summary: Cleanup: mayDisplaySeamlessWithParent -> mayDisplaySeamless_ly_WithParent
Product: WebKit Reporter: Mike West <mkwst>
Component: New BugsAssignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Trivial CC: dglazkov, eric, ojan.autocc, webkit.review.bot
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mike West
Reported 2013-01-05 01:22:58 PST
Cleanup: mayDisplaySeamlessWithParent -> mayDisplaySeamless_ly_WithParent
Attachments
Patch (3.33 KB, patch)
2013-01-05 01:24 PST, Mike West 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2013-01-05 01:24:12 PST
Created attachment 181431 [details] Patch
Mike West
Comment 2 2013-01-05 01:26:11 PST
I typo'd this twice while working on an earlier patch; adverbial forms matter! Note that Document::shouldDisplaySeamlesslyWithParent was already correct. :) Eric, mind taking a quick look at this trivial change?
Eric Seidel (no email)
Comment 3 2013-01-05 01:32:02 PST
Comment on attachment 181431 [details] Patch OK. Be aware hyatt may have a patch in flight, would be nice not to break him. I'm not sure if his column + seamless patch from earlier today landed or not.
Mike West
Comment 4 2013-01-05 01:34:08 PST
This is a loooow priority patch; I'm happy to wait till next week to land it. Thanks for the warning.
WebKit Review Bot
Comment 5 2013-01-05 02:54:45 PST
Comment on attachment 181431 [details] Patch Attachment 181431 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15708765 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
WebKit Review Bot
Comment 6 2013-01-05 13:08:24 PST
Comment on attachment 181431 [details] Patch Clearing flags on attachment: 181431 Committed r138906: <http://trac.webkit.org/changeset/138906>
WebKit Review Bot
Comment 7 2013-01-05 13:08:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.