Summary: | Cleanup: mayDisplaySeamlessWithParent -> mayDisplaySeamless_ly_WithParent | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mike West <mkwst> | ||||
Component: | New Bugs | Assignee: | Mike West <mkwst> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Trivial | CC: | dglazkov, eric, ojan.autocc, webkit.review.bot | ||||
Priority: | P5 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mike West
2013-01-05 01:22:58 PST
Created attachment 181431 [details]
Patch
I typo'd this twice while working on an earlier patch; adverbial forms matter! Note that Document::shouldDisplaySeamlesslyWithParent was already correct. :) Eric, mind taking a quick look at this trivial change? Comment on attachment 181431 [details]
Patch
OK. Be aware hyatt may have a patch in flight, would be nice not to break him. I'm not sure if his column + seamless patch from earlier today landed or not.
This is a loooow priority patch; I'm happy to wait till next week to land it. Thanks for the warning. Comment on attachment 181431 [details] Patch Attachment 181431 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15708765 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Comment on attachment 181431 [details] Patch Clearing flags on attachment: 181431 Committed r138906: <http://trac.webkit.org/changeset/138906> All reviewed patches have been landed. Closing bug. |