Bug 106169

Summary: Cleanup: mayDisplaySeamlessWithParent -> mayDisplaySeamless_ly_WithParent
Product: WebKit Reporter: Mike West <mkwst>
Component: New BugsAssignee: Mike West <mkwst>
Severity: Trivial CC: dglazkov, eric, ojan.autocc, webkit.review.bot
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Mike West 2013-01-05 01:22:58 PST
Cleanup: mayDisplaySeamlessWithParent -> mayDisplaySeamless_ly_WithParent
Comment 1 Mike West 2013-01-05 01:24:12 PST
Created attachment 181431 [details]
Comment 2 Mike West 2013-01-05 01:26:11 PST
I typo'd this twice while working on an earlier patch; adverbial forms matter!

Note that Document::shouldDisplaySeamlesslyWithParent was already correct. :)

Eric, mind taking a quick look at this trivial change?
Comment 3 Eric Seidel (no email) 2013-01-05 01:32:02 PST
Comment on attachment 181431 [details]

OK.  Be aware hyatt may have a patch in flight, would be nice not to break him.  I'm not sure if his column + seamless patch from earlier today landed or not.
Comment 4 Mike West 2013-01-05 01:34:08 PST
This is a loooow priority patch; I'm happy to wait till next week to land it.

Thanks for the warning.
Comment 5 WebKit Review Bot 2013-01-05 02:54:45 PST
Comment on attachment 181431 [details]

Attachment 181431 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15708765

New failing tests:
Comment 6 WebKit Review Bot 2013-01-05 13:08:24 PST
Comment on attachment 181431 [details]

Clearing flags on attachment: 181431

Committed r138906: <http://trac.webkit.org/changeset/138906>
Comment 7 WebKit Review Bot 2013-01-05 13:08:28 PST
All reviewed patches have been landed.  Closing bug.