Bug 106157
| Summary: | run-webkit-tests shouldn't pass --debug-rwt-logging on the buildbots anymore | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | dpranke, lforschler, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Eric Seidel (no email)
run-webkit-tests shouldn't pass --debug-rwt-logging on the buildbots anymore
I don't think we're getting much from the debug logging, besides making the real errors more difficult to see, and creating gigabyte log files. :)
Maybe I'm naive, and we should really be logging as much as possible? But I think we're not getting much value from the verbosity and should remove it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Note that large log files are slowing buildbot down. In particular, the recent verbosity on leak bots caused 502/503 errors on build.webkit.org.
Eric Seidel (no email)
In the case of leaks. The vast majority of the file is from leaks spew. :) That should hopefully largely be resolved by investigations relating to bug 106137.
Dirk Pranke
We don't log as much as possible; we log what has usually been found useful in the past, and the log spew is like all log spew: it's not useful, except when it is :).
That said, now that NRWT is pretty stable, I don't often need to see as much of the log as I used to to debug things. If there is a real impact on the bots somewhere, we could certainly try turning off --debug-rwt-logging by default and only turn it back on when we need to troubleshoot bot issues.
Note that w/o --debug-rwt-logging it will be very difficult to troubleshoot any issues on the bots, though, so we might consider an alternative where we eliminate some of the messages that produce much of the logs (like mentioning tests that run successfully) but save the rest.
Ryosuke Niwa
You can log the bot output in a .log or .txt files, and upload that along with results.html. The problem is to do with outputting that on stdout.